Yes, I have that removed. Thanks for the review!
- Kurchi
On 6/18/2013 1:57 AM, Chris Hegarty wrote:
For the purposes of this issue, I think your changes to hashCode are
in line with the equals implementation. Trivially, you could also
remove the '(obj != null) ' from equals ;-) Otherwise,
On 6/14/2013 11:56 PM, Alan Bateman wrote:
On 14/06/2013 23:59, Kurchi Hazra wrote:
Hi,
This is to elimnate the overrides warning from ClassDeclaration.java.
This class is used by rmi, but sun/tools/java and
sun/tools/javac also heavily uses it, let me know if anyone else
should also be
I spent some more time reviewing this, I believe the equals()
implementation is correct. Given one string, we get a unique
Identifier. The Identifier has the associated Type cached - so given an
Identifier, we get a unique Type too. One usage of the
ClassDeclaration#equals() method is in
On 14/06/2013 23:59, Kurchi Hazra wrote:
Hi,
This is to elimnate the overrides warning from ClassDeclaration.java.
This class is used by rmi, but sun/tools/java and
sun/tools/javac also heavily uses it, let me know if anyone else
should also be reviewing it.
Bug:
Hi,
This is to elimnate the overrides warning from ClassDeclaration.java.
This class is used by rmi, but sun/tools/java and
sun/tools/javac also heavily uses it, let me know if anyone else should
also be reviewing it.
Bug: http://bugs.sun.com/view_bug.do?bug_id=8016698 [To appear]
Webrev:
