Re: Codereview needed for #6929479

2010-03-11 Thread Xueming Shen
Alan Bateman wrote: Xueming Shen wrote: Alan, webrev has been updated to use the sun.zip.disableMemoryMapping http://cr.openjdk.java.net/~sherman/6929479/webrev Please review. Thanks, Sherman I agree it's a better name. In ZipFile it would be good to put a comment at the initialization so

Re: Codereview needed for #6929479

2010-03-11 Thread Alan Bateman
Xueming Shen wrote: Alan, webrev has been updated to use the sun.zip.disableMemoryMapping http://cr.openjdk.java.net/~sherman/6929479/webrev Please review. Thanks, Sherman I agree it's a better name. In ZipFile it would be good to put a comment at the initialization so that the reader under

Re: Codereview needed for #6929479

2010-03-10 Thread Xueming Shen
Alan, webrev has been updated to use the sun.zip.disableMemoryMapping http://cr.openjdk.java.net/~sherman/6929479/webrev Please review. Thanks, Sherman Alan Bateman wrote: Xueming Shen wrote: : The webrev has been updated to use "sun.zip.disableMmapping", I guess you meant "sun.zip.disable

Re: Codereview needed for #6929479

2010-02-27 Thread Martin Buchholz
I think some documentation of the problem, and a practical description of how users can deal with it, is the most important thing. Old unix-isms, like cp test/foo.jar production/foo.jar jar cf production/foo.jar ... some...unix..command > production/foo.jar rsync -a test/ production/ need to be e

Re: Codereview needed for #6929479

2010-02-27 Thread Christos Zoulas
On Feb 27, 5:49pm, marti...@google.com (Martin Buchholz) wrote: -- Subject: Re: Codereview needed for #6929479 | On Thu, Feb 25, 2010 at 12:09, Lance J. Andersen wrote: | > Going forward, should we be using sun or oracle in the property names? | | It is impractical to stamp out the "

Re: Codereview needed for #6929479

2010-02-27 Thread Martin Buchholz
On Thu, Feb 25, 2010 at 12:09, Lance J. Andersen wrote: > Going forward, should we be using sun or oracle in the property names? It is impractical to stamp out the "sun" in the API, even though it's "private". There are too many references to sun.* in third party code to consider a massive renam

Re: Codereview needed for #6929479

2010-02-25 Thread Lance J. Andersen
Going forward, should we be using sun or oracle in the property names? -lance Alan Bateman wrote: Xueming Shen wrote: : The webrev has been updated to use "sun.zip.disableMmapping", I guess you meant "sun.zip.disableMmapping", right? It's hard to find a good name. I was suggesting disableMapp

Re: Codereview needed for #6929479

2010-02-25 Thread Alan Bateman
Xueming Shen wrote: : The webrev has been updated to use "sun.zip.disableMmapping", I guess you meant "sun.zip.disableMmapping", right? It's hard to find a good name. I was suggesting disableMapping (no double m) but disableMemoryMapping could work too. -Alan.

Re: Codereview needed for #6929479

2010-02-25 Thread Xueming Shen
Alan Bateman wrote: Xueming Shen wrote: http://cr.openjdk.java.net/~sherman/6929479/webrev/ This is a rfe to add a system property sun.zip.disableMmap to enable the end user to disable the mmap usage in Sun's java.util.zip.ZipFile implementaiton (for Solaris and Linux platforms). Applicati

Re: Codereview needed for #6929479

2010-02-25 Thread Alan Bateman
Xueming Shen wrote: http://cr.openjdk.java.net/~sherman/6929479/webrev/ This is a rfe to add a system property sun.zip.disableMmap to enable the end user to disable the mmap usage in Sun's java.util.zip.ZipFile implementaiton (for Solaris and Linux platforms). Application uses java.util.zip

Codereview needed for #6929479

2010-02-25 Thread Xueming Shen
http://cr.openjdk.java.net/~sherman/6929479/webrev/ This is a rfe to add a system property sun.zip.disableMmap to enable the end user to disable the mmap usage in Sun's java.util.zip.ZipFile implementaiton (for Solaris and Linux platforms). Application uses java.util.zip.ZipFile might experi