Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread Gregg Wonderly
On Jun 26, 2012, at 10:02 AM, Alan Bateman wrote: > > Do the tests assume they are run on HFS? Just wondering if you you need to > look at the FileStore name/type to check. TensComplement's ZFS port (ZEVO) to MacOSX may need some consideration if HFS is going to be the only test bed. Gregg W

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread David Kocher
Will this address issue MACOSX_PORT-165 [1]? [1] http://java.net/jira/browse/MACOSX_PORT-165 -- David On 22.06.2012, at 19:01, Xueming Shen wrote: > Hi > > Here is the proposed change to support Unicode nfd/nfc and case insensitive > file path on MacOSX file system. > > 7130915: File.equals

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread David Kocher
I welcome this issue is getting some serious attention then. When will this be backported to 7u? -- David On 24.06.2012, at 18:58, Xueming Shen wrote: > > Yes, I believe the issue described in MACOSX_PORT-165 is the > same issue this patch is trying to solve. > > Btw, it appears there are typ

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread Xueming Shen
Thanks Alan! The webrev has been updated to throw OOME as your other nio native dispatcher does. http://cr.openjdk.java.net/~sherman/7130915/webrev. I can wait for your back from the vacation:-) -Sherman On 6/26/12 11:41 PM, Alan Bateman wrote: On 27/06/2012 04:33, Xueming Shen wrote: Al

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-26 Thread Alan Bateman
On 27/06/2012 04:33, Xueming Shen wrote: Alan, Webrev has been updated accordingly at http://cr.openjdk.java.net/~sherman/7130915/webrev with changes (1) added a CFStringCreateMutable(...) != null check in both io and nio native, though it is unlikely to fail here because we are passin

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-26 Thread Xueming Shen
Alan, Webrev has been updated accordingly at http://cr.openjdk.java.net/~sherman/7130915/webrev with changes (1) added a CFStringCreateMutable(...) != null check in both io and nio native, though it is unlikely to fail here because we are passing a NULL and 0 length, like new StringBui

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-26 Thread Alan Bateman
On 26/06/2012 07:00, Xueming Shen wrote: On 6/25/12 10:58 PM, Xueming Shen wrote: Hi, While I still believe that case-insensitive is the right choice for File/Path on MacOSX, it is suggested that we might want to be a little conservative in this patch, with the assumption that this patch will

Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-25 Thread Xueming Shen
On 6/25/12 10:58 PM, Xueming Shen wrote: Hi, While I still believe that case-insensitive is the right choice for File/Path on MacOSX, it is suggested that we might want to be a little conservative in this patch, with the assumption that this patch will be backport to 7u release after being bak

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-24 Thread Xueming Shen
Yes, I believe the issue described in MACOSX_PORT-165 is the same issue this patch is trying to solve. Btw, it appears there are typos in the note(2), my mini keyboard obviously is too sticky:-) (2) normalize the resulting file name from macosx fs APIs from nfd->nfc before passing back to

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-23 Thread Alan Bateman
On 22/06/2012 19:02, Mike Duigou wrote: : Won't this cause problems on case sensitive file systems? The MacOSX filesystem is by default case insensitive but case sensitive file systems are not entirely uncommon. It shouldn't cause any issues accessing files, this is really just about equals,

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Xueming Shen
On 6/22/12 11:02 AM, Mike Duigou wrote: On Jun 22 2012, at 10:01 , Xueming Shen wrote: Hi Here is the proposed change to support Unicode nfd/nfc and case insensitive file path on MacOSX file system. 7130915: File.equals does not give expected results when path contains Non-English characters

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Naoto Sato
Hi Sherman, There are several places where Locale.ENGLISH is used for locale neutral processing. You could instead use Locale.ROOT for that purpose. Naoto On 12/06/22 10:01, Xueming Shen wrote: Hi Here is the proposed change to support Unicode nfd/nfc and case insensitive file path on MacOS

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Mike Duigou
On Jun 22 2012, at 10:01 , Xueming Shen wrote: > Hi > > Here is the proposed change to support Unicode nfd/nfc and case insensitive > file path on MacOSX file system. > > 7130915: File.equals does not give expected results when path contains > Non-English characters on Mac OS X > 7168427: File

Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-22 Thread Xueming Shen
Hi Here is the proposed change to support Unicode nfd/nfc and case insensitive file path on MacOSX file system. 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X 7168427: FileInputStream cannot open file where the file path contains asian