Re: Constructor `String(String)` does not copy `hashIsZero`

2021-11-22 Thread Japris Pogrammer
Thanks, I've created the PR [1] with the fix. [1]: https://github.com/openjdk/jdk/pull/6511 вт, 23 нояб. 2021 г., 01:42 Claes Redestad : > Hi, > > this appears to be unintentionally left out. I've filed a bug[1]. > > While marked as an @IntrinsicCandidate, I can't see that HotSpot/C2 is > actual

Re: Constructor `String(String)` does not copy `hashIsZero`

2021-11-22 Thread Claes Redestad
Hi, this appears to be unintentionally left out. I've filed a bug[1]. While marked as an @IntrinsicCandidate, I can't see that HotSpot/C2 is actually intrinsifying this constructor. The signature is used for some pattern matching in the legacy stringopts.cpp code, though. So the trivial fix shou

Constructor `String(String)` does not copy `hashIsZero`

2021-11-22 Thread Japris Pogrammer
According to openjdk/jdk [1] current copy-constructor of String class does not copy the value of hashIsZero field which may lead to 0-hash being recalculated on copy even if it is known to be 0. Could you please tell me if I am right with this point or if this behaviour is intentional? If this is a