Re: Faster double parser?

2021-04-06 Thread Raffaello Giulietti
Hi, yes, the code in itself is current. I would need to adapt it to OpenJDK coding conventions; in particular the form of multiline comments is not the usual one. Only cosmetic changes, though. Nothing would affect the executable code. Also, the current patch modifies some existing files, so

Re: Faster double parser?

2021-04-06 Thread Brian Burkhalter
On Apr 6, 2021, at 3:40 PM, Raffaello Giulietti mailto:raffaello.giulie...@gmail.com>> wrote: if there's revived interest I would be glad to migrate the code to Skara/GitHub for a PR. The last uploaded version is still on Mercurial, I assume, under Brian Burkhalter's webrev folder. Is the Hg

Re: Faster double parser?

2021-04-06 Thread Raffaello Giulietti
Hi, if there's revived interest I would be glad to migrate the code to Skara/GitHub for a PR. The last uploaded version is still on Mercurial, I assume, under Brian Burkhalter's webrev folder. But I'd also like to point out that there is a pending CSR as well. (Sorry for the initiator of thi

Re: Faster double parser?

2021-04-05 Thread Brian Burkhalter
The mailing list mangled formatting. My comments are prefixed below by “->”. On Apr 5, 2021, at 9:52 AM, Brian Burkhalter mailto:brian.burkhal...@oracle.com>> wrote: On Apr 5, 2021, at 4:11 AM, Andrew Haley mailto:a...@redhat.com>> wrote: On 4/5/21 9:08 AM, Alan Bateman

Re: Faster double parser?

2021-04-05 Thread Brian Burkhalter
The mailing list mangled formatting. My comments are prefixed below by “->”. On Apr 5, 2021, at 9:52 AM, Brian Burkhalter mailto:brian.burkhal...@oracle.com>> wrote: On Apr 5, 2021, at 4:11 AM, Andrew Haley mailto:a...@redhat.com>> wrote: On 4/5/21 9:08 AM, Alan Bateman

Re: Faster double parser?

2021-04-05 Thread Brian Burkhalter
On Apr 5, 2021, at 4:11 AM, Andrew Haley mailto:a...@redhat.com>> wrote: On 4/5/21 9:08 AM, Alan Bateman wrote: On 04/04/2021 09:53, Andrew Haley wrote: : We also have a candidate for a String -> toDouble parser from Raffaello Giulietti: https://mail.openjdk.java.net/pipermail/core-libs-dev/201

Re: Faster double parser?

2021-04-05 Thread Andrew Haley
On 4/5/21 9:08 AM, Alan Bateman wrote: > On 04/04/2021 09:53, Andrew Haley wrote: >> : >> We also have a candidate for a String -> toDouble parser from Raffaello >> Giulietti: >> >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052355.html >> >> As far as I can see there's nothin

Re: Faster double parser?

2021-04-05 Thread Alan Bateman
On 04/04/2021 09:53, Andrew Haley wrote: : We also have a candidate for a String -> toDouble parser from Raffaello Giulietti: https://mail.openjdk.java.net/pipermail/core-libs-dev/2018-March/052355.html As far as I can see there's nothing wrong with it, but it got stuck in review. This was a ba

Re: Faster double parser?

2021-04-04 Thread Andrew Haley
On 4/4/21 9:53 AM, Andrew Haley wrote: > On 4/3/21 12:58 PM, Carfield Yim wrote: >> HI all, just aware of this project, >> https://github.com/wrandelshofer/FastDoubleParser, not sure if it good idea >> to use this as default Double Parser in JVM? > > We also have a candidate for a String -> toDoub

Re: Faster double parser?

2021-04-04 Thread Andrew Haley
On 4/3/21 12:58 PM, Carfield Yim wrote: > HI all, just aware of this project, > https://github.com/wrandelshofer/FastDoubleParser, not sure if it good idea > to use this as default Double Parser in JVM? We also have a candidate for a String -> toDouble parser from Raffaello Giulietti: https://mai

Faster double parser?

2021-04-03 Thread Carfield Yim
HI all, just aware of this project, https://github.com/wrandelshofer/FastDoubleParser, not sure if it good idea to use this as default Double Parser in JVM?