Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-18 Thread Brian Burkhalter
This RFR was initially posted last month: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016999.html I hope that this is the final re-post. The issues in question are http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4837946 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-18 Thread Brian Burkhalter
On Jun 18, 2013, at 5:51 PM, Martin Buchholz wrote: > As always, I hope that those folks who deeply understand math stuff can be > empowered to submit/review. > Looks good, except for some minor style issues: > Probably want to leave debug print commented out in the final version? > -

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-19 Thread Alan Eliasen
On 06/18/2013 06:13 PM, Brian Burkhalter wrote: > This RFR was initially posted last month: > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016999.html > > I hope that this is the final re-post. The issues in question are > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-19 Thread Alan Bateman
On 19/06/2013 01:13, Brian Burkhalter wrote: This RFR was initially posted last month: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/016999.html I hope that this is the final re-post. The issues in question are http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4837946 http://b

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-19 Thread Brian Burkhalter
I think Tim is involved only in phases 3 and 4 of the BigInteger improvements so we could remove him as author for now. His OCA status should however be cleared up soon as I am hoping to move onto phase 3 before long. Brian On Jun 19, 2013, at 5:58 AM, Alan Bateman wrote: > One question on the

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-19 Thread Brian Burkhalter
I have updated this webrev per Martin's comments and removed Tim from the @author list. If the latter is incorrect, please let me know. Brian On Jun 18, 2013, at 5:13 PM, Brian Burkhalter wrote: > the webrev as before is at > > http://cr.openjdk.java.net/~bpb/4837946/

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-19 Thread Alan Bateman
On 19/06/2013 16:14, Brian Burkhalter wrote: I have updated this webrev per Martin's comments and removed Tim from the @author list. If the latter is incorrect, please let me know. Brian Thanks, I think we are good now. -Alan

Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers

2013-06-19 Thread Brian Burkhalter
Alan, On Jun 19, 2013, at 5:27 AM, Alan Eliasen wrote: > Thanks for pushing this improvement. As I've said before, I'm more > than willing to put my personal e-mail address on this patch to support > the Karatsuba and Toom-Cook and pow() and radix conversion fixes. I'll > put my reputation on t

Attributions (was Re: Final RFR 4837946: Faster multiplication and exponentiation of large integers)

2013-06-19 Thread Weijun Wang
On 6/19/2013 8:58 PM, Alan Bateman wrote: One question on the attribution (so that we have it right). In the Contributed-by line then you have Alan Eliasen listed but the @author tags have been extended to list Tim Buktu in addition to Alan. Is the patch from both Alan and Tim? I ask because I