Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-10 Thread Lance Andersen - Oracle
Hi Frank, As I explained in one of my earlier emails, tests that require a database will not be added to jtreg. I have a unit test suite which i use for that but that is not external Best Lance On Dec 10, 2012, at 2:44 AM, Frank Ding wrote: > Hi Lance, > The code refactory looks good. By

Re: Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-09 Thread Frank Ding
Hi Lance, The code refactory looks good. By the way, the newly added unit test is not jtreg test case? Best regards, Frank On 12/5/2012 4:38 AM, Lance Andersen - Oracle wrote: All, Attached is the patch for: 8004374 based off the issue that Frank reported. for http://cr.openjdk.java.

Review needed: 8004374 : Fwd: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-04 Thread Lance Andersen - Oracle
All, Attached is the patch for: 8004374 based off the issue that Frank reported. for http://cr.openjdk.java.net/~lancea/8004374/webrev.00/ The TCK, SQE and the JDBC Unit Tests run clean. I added a new Unit Test to validate the issue. Frank, I did not use your fix as I was able to clean the

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-03 Thread Lance Andersen - Oracle
I will get to it sometime within the next week. Have some higher priority items to address first Best Lance On Dec 3, 2012, at 3:17 AM, Frank Ding wrote: > Hi Lance, > Thanks for your clarification. I created the test case you requested and > attached it in this email. Please review it. By

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-12-03 Thread Frank Ding
Hi Lance, Thanks for your clarification. I created the test case you requested and attached it in this email. Please review it. By the way, the new Oracle bug (internal id 2376620) submitted by me several days ago seems not having been reviewed. Could you also help me on this? Best rega

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-30 Thread Lance Andersen - Oracle
Hi Frank, Thank you for the email. No we do not want tests that require database access in jtreg. What I was trying to say, albeit not probably as clear as it could have been is that it would be helpful to provide a complete example and to use Java DB as the database if it is a generic data a

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-29 Thread Frank Ding
Hi Lance, Sorry for late response and thanks for your comment. You mean I can write a jtreg test case that connects to Java DB? I can do that. Best regards, Frank On 11/13/2012 10:13 PM, Lance Andersen - Oracle wrote: Hi Frank, Thank you for the note If you could in the future, please p

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-13 Thread Lance Andersen - Oracle
Hi Frank, Thank you for the note If you could in the future, please provide a complete test program to repro the issue as it would save time with the reviews. Ideally if the issue is not database specific it would be good to leverage Java DB as it is included within Oracle JDK I will look

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-12 Thread Frank Ding
Hi Lance Thanks for your quick response. Please find the bug info below. The problem: When CachedRowSetImpl.acceptChanges() is called, incorrect number of conflicts, if any, is reported. The number of conflicts is the actual number of existing rows in database, which is the size of vari

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-09 Thread Lance Andersen - Oracle
Frank, If you can please post the bug info here, I will take a look at your patch Best Lance On Nov 8, 2012, at 10:01 PM, Frank Ding wrote: > Hi guys, > We discovered a bug in CachedRowSetWriter.writeData method where incorrect > number of conflicts is reported. I searched in Oracle bug datab

JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-08 Thread Frank Ding
Hi guys, We discovered a bug in CachedRowSetWriter.writeData method where incorrect number of conflicts is reported. I searched in Oracle bug database and no similar record was found. So I submitted a new one whose internal review ID is 2376620. A test case with code is illustrated in the