Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Henry Jen
rking on a test, do you want me to share directly with you (incl. > questions) or continue with comms through the mailing list > > Cheers > Mat > > From: Henry Jen > Sent: Monday, November 4, 2019 12:47 PM > To: Mat Carter > Cc: core-libs-dev@openjdk.java.net &g

Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Mat Carter
@openjdk.java.net Subject: Re: JDK-8231863 bug fix candidate Hi Mat, I’ll sponsor this fix, let me know if you are coming up with test and I’ll work with you to get your patch committed. Cheers, Henry > On Nov 4, 2019, at 9:21 AM, Henry Jen wrote: > > The fix is on the spot, good catch. > &

Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Mat Carter
From: Henry Jen Sent: Monday, November 4, 2019 9:21 AM To: Mat Carter Cc: core-libs-dev@openjdk.java.net Subject: Re: JDK-8231863 bug fix candidate The fix is on the spot, good catch. As the test, test/jdk/tools/launcher/ArgsFileTest.java is testing the file expansions, we can add

Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Henry Jen
Hi Mat, I’ll sponsor this fix, let me know if you are coming up with test and I’ll work with you to get your patch committed. Cheers, Henry > On Nov 4, 2019, at 9:21 AM, Henry Jen wrote: > > The fix is on the spot, good catch. > > As the test, test/jdk/tools/launcher/ArgsFileTest.java is

Re: JDK-8231863 bug fix candidate

2019-11-04 Thread Henry Jen
The fix is on the spot, good catch. As the test, test/jdk/tools/launcher/ArgsFileTest.java is testing the file expansions, we can add a test case there to have an argument file not have newline at the end, and check that we get correct arguments. Cheers, Henry > On Nov 1, 2019, at 7:06 AM,

JDK-8231863 bug fix candidate

2019-11-01 Thread Mat Carter
Hello core-libs-dev I'm a VM engineer at Microsoft, now that we've signed the OCA (news of which was shared by Bruno Borges in the discuss mailing list) I wanted to pick up an issue in order to gain familiarity with the change process After reproducing the error reported in "JDK-8231863: Crash