On 7/25/17 1:15 AM, Mandy Chung wrote:
Webrev updated:http://cr.openjdk.java.net/~amlu/8183377/webrev.01/
Looks good. One minor suggestion is to place the source files under a
directory showing its package hierachy e.g. src/comSA/Alice.java,
src/comSB/Bob.java
No need for a new webrev.
Than
> On Jul 17, 2017, at 12:49 AM, Amy Lu wrote:
>
> On 7/14/17 4:41 PM, Mandy Chung wrote:
>> I think compiling the other classes to a destination explicitly to replace:
>> 29 * @build Alice Bob SupAlice SupBob
>> 30 * @run driver SetupLoader
>>
>> will make the test clearer. It’d be good
On 7/14/17 4:41 PM, Mandy Chung wrote:
I think compiling the other classes to a destination explicitly to replace:
29 * @build Alice Bob SupAlice SupBob
30 * @run driver SetupLoader
will make the test clearer. It’d be good to make that change.
Webrev updated: http://cr.openjdk.java.ne
> On Jul 14, 2017, at 4:26 PM, Weijun Wang wrote:
>
>
>> On Jul 14, 2017, at 4:23 PM, Mandy Chung wrote:
>>
>>
>>> On Jul 13, 2017, at 5:14 PM, Amy Lu wrote:
>>>
>>> java/lang/ClassLoader/deadlock/TestCrossDelegate.sh
>>> java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
>>>
>>> Please
> On Jul 14, 2017, at 4:23 PM, Mandy Chung wrote:
>
>
>> On Jul 13, 2017, at 5:14 PM, Amy Lu wrote:
>>
>> java/lang/ClassLoader/deadlock/TestCrossDelegate.sh
>> java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
>>
>> Please review this patch to refactor the shell tests to java.
>>
>> bug
> On Jul 13, 2017, at 5:14 PM, Amy Lu wrote:
>
> java/lang/ClassLoader/deadlock/TestCrossDelegate.sh
> java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
>
> Please review this patch to refactor the shell tests to java.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8183377
> http://cr.op
java/lang/ClassLoader/deadlock/TestCrossDelegate.sh
java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
Please review this patch to refactor the shell tests to java.
bug: https://bugs.openjdk.java.net/browse/JDK-8183377
http://cr.openjdk.java.net/~amlu/8183377/webrev.00/
Thanks,
Amy
