at the cost of
the code being less readable).
(in that case, you have also to change the same code in Executable).
regards,
Rémi
- Mail original -
De: "joe darcy"
À: "Stuart Marks"
Cc: "core-libs-dev"
Envoyé: Mercredi 16 Janvier 2019 04:05:05
Objet: Re: JDK 13 R
o change the same code in Executable).
regards,
Rémi
- Mail original -
> De: "joe darcy"
> À: "Stuart Marks"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 16 Janvier 2019 04:05:05
> Objet: Re: JDK 13 RFR of JDK-8217000: Refactor Class::methodToString
Good catch on the 3-argument joining in this case; I'll push with that
amendment.
Thanks for the review,
-Joe
On 1/15/2019 3:19 PM, Stuart Marks wrote:
On 1/14/19 7:41 PM, Joe Darcy wrote:
PS And for good measure, made analogous changes in Executable.java:
http://cr.openjdk.java.net/
On 1/14/19 7:41 PM, Joe Darcy wrote:
PS And for good measure, made analogous changes in Executable.java:
http://cr.openjdk.java.net/~darcy/8217000.1/
Thanks for following up on this. Overall, looks good. One point:
114 sb.append('(');
115
116 sb.append(Array
* Joe Darcy:
> - sb.append(Stream.of(typeparms).map(Class::typeVarBounds).
> - collect(Collectors.joining(",", "<", ">")));
> + sb.append(Arrays.stream(typeparms)
> + .map(Class::typeVarBounds)
> + .collect(C
PS And for good measure, made analogous changes in Executable.java:
http://cr.openjdk.java.net/~darcy/8217000.1/
Patch:
--- old/src/java.base/share/classes/java/lang/reflect/Executable.java
2019-01-14 19:39:53.855000999 -0800
+++ new/src/java.base/share/classes/java/lang/reflect/Executable
Hello,
Please review a small factoring of several methods in java.lang.Class:
JDK-8217000: Refactor Class::methodToString
http://cr.openjdk.java.net/~darcy/8217000.0/
Patch below; thanks,
-Joe
--- old/src/java.base/share/classes/java/lang/Class.java 2019-01-14
18:05:22.194000999 -080
