Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

-- De: "Martin Buchholz" À: "Tagir Valeev" Cc: "core-libs-dev" Envoyé: Vendredi 8 Mars 2019 21:35:59 Objet: Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull On Fri, Mar 8, 2019 at 3:57 AM Tagir Valeev wrote: Hello! diff -r

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

-throw new NullPointerException(NULL_CAUSE_MESSAGE); > +Objects.requireNonNull(exception, NULL_CAUSE_MESSAGE); > > if (suppressedExceptions == null) // Suppressed exceptions not > recorded > return; > > Thanks, > > -Joe > > On

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

On 2019-03-11 18:59, Mandy Chung wrote: The updated patch looks good. Mandy +1 /Claes

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

The updated patch looks good. Mandy On 3/11/19 9:29 AM, Joe Darcy wrote: Hello, Always surprising how much discussion an (apparently) simple refactoring can generate! Thanks to Tagir for spotting this issue. For completeness, the two-argument forms of requireNonNull which takes a Supplier

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

ev" Cc: "core-libs-dev" Envoyé: Vendredi 8 Mars 2019 21:35:59 Objet: Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull On Fri, Mar 8, 2019 at 3:57 AM Tagir Valeev wrote: Hello! diff -r 274361bd6915 src/java.base/share/classes/java/lang/Th

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

On 3/10/19 9:19 PM, Martin Buchholz wrote: We should stop discussing this here, but ... ... I think that we really should, but ... On Sun, Mar 10, 2019 at 1:51 AM Peter Levart > wrote: In this particular case, this is not true. A lambda that captures

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

We should stop discussing this here, but ... On Sun, Mar 10, 2019 at 1:51 AM Peter Levart wrote: > > In this particular case, this is not true. A lambda that captures no > local or instance state is lazily constructed just once (when the lambda > expression is 1st evaluated) and then it is used

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

- Mail original - > De: "Martin Buchholz" > À: "Tagir Valeev" > Cc: "core-libs-dev" > Envoyé: Vendredi 8 Mars 2019 21:35:59 > Objet: Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use > Objects.requireNonNull >

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

(forgot to send to the list also, so this one if for the list...) On 3/9/19 3:12 PM, Martin Buchholz wrote: As an old lisper, I would personally love to see syntactic abstraction, but also understand that this is not in the spirit of Java. Given the lack of syntactic abstraction, writing all o

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

On 3/8/19 12:35 PM, Martin Buchholz wrote: On Fri, Mar 8, 2019 at 3:57 AM Tagir Valeev wrote: Hello! diff -r 274361bd6915 src/java.base/share/classes/java/lang/Throwable.java --- a/src/java.base/share/classes/java/lang/Throwable.javaThu Mar 07 10:22:19 2019 +0100 +++ b/src/java.base/s

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

On Fri, Mar 8, 2019 at 3:57 AM Tagir Valeev wrote: > Hello! > > > diff -r 274361bd6915 src/java.base/share/classes/java/lang/Throwable.java > > --- a/src/java.base/share/classes/java/lang/Throwable.javaThu Mar 07 > > 10:22:19 2019 +0100 > > +++ b/src/java.base/share/classes/java/lang/Throwabl

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

Looks good to me. Mandy On 3/8/19 3:08 AM, Joe Darcy wrote: Hello, The code in java.lang.Throwable has various explicit null checks that could be rewritten to use Objects.requireNonNull. Please review the patch below which implements this refactoring. Thanks, -Joe diff -r 274361bd6915 sr

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

Hello! > diff -r 274361bd6915 src/java.base/share/classes/java/lang/Throwable.java > --- a/src/java.base/share/classes/java/lang/Throwable.javaThu Mar 07 > 10:22:19 2019 +0100 > +++ b/src/java.base/share/classes/java/lang/Throwable.javaFri Mar 08 > 02:06:42 2019 -0800 > @@ -874,8 +874,7 @@

Re: JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

+1 > On Mar 8, 2019, at 6:08 AM, Joe Darcy wrote: > > Hello, > > The code in java.lang.Throwable has various explicit null checks that could > be rewritten to use Objects.requireNonNull. > > Please review the patch below which implements this refactoring. > > Thanks, > > -Joe > > diff -r 27

JDK 13 RFR of JDK-8220346: Refactor java.lang.Throwable to use Objects.requireNonNull

Hello, The code in java.lang.Throwable has various explicit null checks that could be rewritten to use Objects.requireNonNull. Please review the patch below which implements this refactoring. Thanks, -Joe diff -r 274361bd6915 src/java.base/share/classes/java/lang/Throwable.java --- a/src/ja