Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-09-27 Thread Jonathan Gibbons
Yes, doclint is enforcing the HTML 4.01 spec for JDK 8. http://www.w3.org/TR/REC-html40/ This is in accordance with the DOCTYPE declaration generated at the beginning of all javadoc-generated files. FWIW, is *always* wrong. It would signify an empty paragraph, equivalent to . -- Jon On

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-09-27 Thread Joe Darcy
Adding Jon Gibbons, author of doclint. Sergey, currently doclint is enforcing the rules of HTML 4 rather than HTML 5. At some point in the future, we may migrate to HTML 5. -Joe On 9/27/2013 4:08 AM, Sergey Bylokhov wrote: Hello, I have a question about of = > . Should we follow html speci

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-09-27 Thread Sergey Bylokhov
Hello, I have a question about of = > . Should we follow html specification[1] here or we should always replace to ? [1] http://dev.w3.org/html5/markup/p.html#p see@ Tag omission On 01.07.2013 22:47, Alan Bateman wrote: On 01/07/2013 19:24, Joe Darcy wrote: Hello, Yet another found of docl

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-07-01 Thread Alan Bateman
On 01/07/2013 19:24, Joe Darcy wrote: Hello, Yet another found of doclint fixes for review; this batch to java.lang.instrument. Thanks, -Joe This looks okay to me. -Alan

Re: JDK 8 code review request for doclint issues in java.lang.instrument

2013-07-01 Thread Lance @ Oracle
Looks good Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Jul 1, 2013, at 2:24 PM, Joe Darcy wrote: > Hello, > > Yet another found of doclint fixes for review; t

JDK 8 code review request for doclint issues in java.lang.instrument

2013-07-01 Thread Joe Darcy
Hello, Yet another found of doclint fixes for review; this batch to java.lang.instrument. Thanks, -Joe diff -r 9eaeb1a0aa46 src/share/classes/java/lang/instrument/Instrumentation.java --- a/src/share/classes/java/lang/instrument/Instrumentation.java Sun Jun 30 17:15:47 2013 -0700 +++ b/src