Re: JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

2013-02-19 Thread Alan Bateman
On 19/02/2013 06:58, Joe Darcy wrote: Hello, Please review these two simple fixes for javadoc warnings I noticed during a build (I'll file a bug after getting a review): Looks okay to me too, we seem to have picked up several javadoc warnings recently. -Alan

Re: JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

2013-02-19 Thread Stephen Colebourne
On 19 February 2013 06:58, Joe Darcy joe.da...@oracle.com wrote: diff -r bcde0486261e src/share/classes/java/time/format/DateTimeFormatterBuilder.java --- a/src/share/classes/java/time/format/DateTimeFormatterBuilder.java Mon Feb 18 08:14:18 2013 + +++

Re: JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

2013-02-19 Thread Roger Riggs
HI Joe, These look fine. I'd have been happy to fix these as ongoing ThreeTen work. We'll need to be more careful merging now that changes will be coming from other than the Threeten project. Thanks, Roger On 2/19/13 1:58 AM, Joe Darcy wrote: Hello, Please review these two simple fixes

JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

2013-02-18 Thread Joe Darcy
Hello, Please review these two simple fixes for javadoc warnings I noticed during a build (I'll file a bug after getting a review): diff -r bcde0486261e src/share/classes/java/time/format/DateTimeFormatterBuilder.java --- a/src/share/classes/java/time/format/DateTimeFormatterBuilder.java

Re: JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

2013-02-18 Thread Mike Duigou
Both look fine to me. No need for a webrev. Mike On Feb 18 2013, at 22:58 , Joe Darcy wrote: Hello, Please review these two simple fixes for javadoc warnings I noticed during a build (I'll file a bug after getting a review): diff -r bcde0486261e

Re: JDK 8 request for review: two javadoc warning fixes, on in DateTimeFormatterBuilder, another in TimeZone

2013-02-18 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 2/19/2013 3:58 PM, Joe Darcy wrote: Hello, Please review these two simple fixes for javadoc warnings I noticed during a build (I'll file a bug after getting a review): diff -r bcde0486261e src/share/classes/java/time/format/DateTimeFormatterBuilder.java ---