Re: JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

2016-07-11 Thread Lance Andersen
Hi Brian, Good to go from me :-) > On Jul 11, 2016, at 4:38 PM, Brian Burkhalter > wrote: > > On Jul 11, 2016, at 3:32 AM, Lance Andersen > wrote: > >>> On Jul 11, 2016, at 3:56 AM, Alan Bateman >> > wrote: >>> >>> On 10/07/20

Re: JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

2016-07-11 Thread Brian Burkhalter
On Jul 11, 2016, at 3:32 AM, Lance Andersen wrote: >> On Jul 11, 2016, at 3:56 AM, Alan Bateman wrote: >> >> On 10/07/2016 15:50, Lance Andersen wrote: >> >>> : >>> I had issues in the past where SQE was using read only directories so >>> writing to test.dir would fail for me. So I used the

Re: JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

2016-07-11 Thread Lance Andersen
> On Jul 11, 2016, at 3:56 AM, Alan Bateman wrote: > > On 10/07/2016 15:50, Lance Andersen wrote: > >> : >> I had issues in the past where SQE was using read only directories so >> writing to test.dir would fail for me. So I used the current directory >> instead which is the work directory

Re: JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

2016-07-11 Thread Alan Bateman
On 10/07/2016 15:50, Lance Andersen wrote: : I had issues in the past where SQE was using read only directories so writing to test.dir would fail for me. So I used the current directory instead which is the work directory which will get cleaned up after. You might be thinking `test.src` wh

Re: JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

2016-07-10 Thread Lance Andersen
Hi Brian, > On Jul 8, 2016, at 8:17 PM, Brian Burkhalter > wrote: > > Please review at your convenience. > > Issue:https://bugs.openjdk.java.net/browse/JDK-8160215 > Diff: > > --- a/test/java/io/Reader/ReaderBulkReadContract.java > +++ b/test/java/io/Reader/ReaderBulkReadContract.java

JDK 9 RFR of 8160215: jdk/test/java/io/Reader/ReaderBulkReadContract.java should clean up better

2016-07-08 Thread Brian Burkhalter
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8160215 Diff: --- a/test/java/io/Reader/ReaderBulkReadContract.java +++ b/test/java/io/Reader/ReaderBulkReadContract.java @@ -148,7 +148,8 @@ private static File createTempFileWithContents(String contents)