> On 11 Dec 2016, at 18:07, Amy Lu wrote:
>
> Yes :-)
>
> Fixed for Collisions.testIntegerIteration and Collisions.testStringIteration:
> http://cr.openjdk.java.net/~amlu/8023898/webrev.02/
>
+1
Paul.
Yes :-)
Fixed for Collisions.testIntegerIteration and
Collisions.testStringIteration:
http://cr.openjdk.java.net/~amlu/8023898/webrev.02/
Thanks,
Amy
On 12/10/16 1:01 AM, Paul Sandoz wrote:
Hi Amy,
A nice refactoring and clean up.
For some test cases in Collisions you don’t need to obtain
Hi Amy,
A nice refactoring and clean up.
For some test cases in Collisions you don’t need to obtain the array of keys,
you just need to know the key length, which can be obtained from map.size().
Paul.
> On 8 Dec 2016, at 19:19, Amy Lu wrote:
>
> Please review this test refactoring to map te
Please review this test refactoring to map test Collisions and
InPlaceOpsCollisions.
These tests have (almost) same code for creating test data, and the test
data can be reused cross tests. With converting to testng, test data
creating is now done and provided by MapWithCollisionsProviders.jav
