Re: JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-25 Thread Joe Darcy
Hi Remi, Thanks for the note. However, I don't plan to extend @SafeVarargs to cover this case. Cheers, -Joe On 6/25/2014 1:35 AM, Remi Forax wrote: Hi Joe, Just for completeness, there is another case where @SafeVarargs is safe, any methods of an internal class (inner class static or not)

Re: JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-25 Thread Remi Forax
Hi Joe, Just for completeness, there is another case where @SafeVarargs is safe, any methods of an internal class (inner class static or not) declared private that is not overridden. because the internal class is private, the compiler can easily check all possible subclasses in the compilatio

Re: JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-24 Thread Joe Darcy
On 06/24/2014 10:43 AM, Paul Benedict wrote: Will there be another ticket to update the section (9.6.4.7.) in JLS 9? JDK-8047159: 9.6.4.7: Allow @SafeVarargs on private methods https://bugs.openjdk.java.net/browse/JDK-8047159 Cheers, -Joe Cheers, Paul On Tue, Jun 24, 2014 at 12:

Re: JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-24 Thread Paul Benedict
Will there be another ticket to update the section (9.6.4.7.) in JLS 9? Cheers, Paul On Tue, Jun 24, 2014 at 12:27 PM, Lance Andersen wrote: > +1 > On Jun 24, 2014, at 1:13 PM, Joe Darcy wrote: > > > Hello, > > > > Please review the libraries update portion of allowing @SafeVarargs on > priv

Re: JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-24 Thread Lance Andersen
+1 On Jun 24, 2014, at 1:13 PM, Joe Darcy wrote: > Hello, > > Please review the libraries update portion of allowing @SafeVarargs on > private instance methods: > >JDK-8048014: Update java.lang.SafeVararags for private methods > > The patch is > > diff -r 6c26f18d9bc0 src/share/classes/j

JDK 9 RFR of JDK-8048014: Update java.lang.SafeVararags for private methods

2014-06-24 Thread Joe Darcy
Hello, Please review the libraries update portion of allowing @SafeVarargs on private instance methods: JDK-8048014: Update java.lang.SafeVararags for private methods The patch is diff -r 6c26f18d9bc0 src/share/classes/java/lang/SafeVarargs.java --- a/src/share/classes/java/lang/SafeVara