Re: JDK 9 RFR of JDK-8144321: Improve existent tests to check the exact line numbers in Stack Frame.

2015-12-06 Thread Hamlin Li
Hi Daniel, Thanks for reviewing and suggestions, 1> add big warning to warn maintainer that the tests were dependent on line numbers.; 2> verify line numbers by parsing the source code. I think your second suggestion is great! :-), but to keep the logic simple and straight, I prefer your

Re: JDK 9 RFR of JDK-8144321: Improve existent tests to check the exact line numbers in Stack Frame.

2015-12-05 Thread Daniel Fuchs
HI Hamlin, If I understand well any line, comment, etc, added to the test in the future is likely to make the tests fail because the line numbers will no longer match. I have seen other tests (I think they where compiler tests) which exhibited such a characteristic, but those had a big warning

JDK 9 RFR of JDK-8144321: Improve existent tests to check the exact line numbers in Stack Frame.

2015-12-04 Thread Hamlin Li
Hi all, Would you please help to review the test development of https://bugs.openjdk.java.net/browse/JDK-8144321. webrev : http://cr.openjdk.java.net/~mli/8144321/webrev.00/ Thank you -Hamlin