Re: JDK RFR of 6556996: (ann spec) SuppressWarnings strings should be documented

2013-02-23 Thread Joe Darcy
On 2/23/2013 1:25 AM, Remi Forax wrote: On 02/22/2013 02:46 AM, Joe Darcy wrote: Hello, Please review the simple fix below for 6556996: (ann spec) SuppressWarnings strings should be documented http://bugs.sun.com/view_bug.do?bug_id=6556996 the webrev is at http://cr.openjdk.java.

Re: JDK RFR of 6556996: (ann spec) SuppressWarnings strings should be documented

2013-02-23 Thread Remi Forax
On 02/22/2013 02:46 AM, Joe Darcy wrote: Hello, Please review the simple fix below for 6556996: (ann spec) SuppressWarnings strings should be documented http://bugs.sun.com/view_bug.do?bug_id=6556996 the webrev is at http://cr.openjdk.java.net/~darcy/6556996.0/ and the patch is b

Re: JDK RFR of 6556996: (ann spec) SuppressWarnings strings should be documented

2013-02-23 Thread Chris Hegarty
On 02/22/2013 09:25 PM, Mike Duigou wrote: looks good to me. Nice to see the JLS additions and good catch on the missing @since. +1. -Chris. On Feb 21 2013, at 17:46 , Joe Darcy wrote: Hello, Please review the simple fix below for 6556996: (ann spec) SuppressWarnings strings should

Re: JDK RFR of 6556996: (ann spec) SuppressWarnings strings should be documented

2013-02-22 Thread Mike Duigou
looks good to me. Nice to see the JLS additions and good catch on the missing @since. On Feb 21 2013, at 17:46 , Joe Darcy wrote: > Hello, > > Please review the simple fix below for > >6556996: (ann spec) SuppressWarnings strings should be documented >http://bugs.sun.com/view_bug.do?bu

JDK RFR of 6556996: (ann spec) SuppressWarnings strings should be documented

2013-02-21 Thread Joe Darcy
Hello, Please review the simple fix below for 6556996: (ann spec) SuppressWarnings strings should be documented http://bugs.sun.com/view_bug.do?bug_id=6556996 the webrev is at http://cr.openjdk.java.net/~darcy/6556996.0/ and the patch is below. In brief, the only required string t