Re: RFR: 8244146: javac changes for JEP 306 [v3]

2021-05-05 Thread Joe Darcy
On Wed, 5 May 2021 11:05:11 GMT, Jan Lahoda wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line >> 1704: >> >>> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source)) >>> 1703: result = result & ~STRICTFP; >>> 1704: >> >> Nitpick:

Re: RFR: 8244146: javac changes for JEP 306 [v2]

2021-05-05 Thread Joe Darcy
On Wed, 5 May 2021 18:03:54 GMT, Naoto Sato wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java line 290: > >> 288: >> 28

Re: RFR: 8244146: javac changes for JEP 306 [v3]

2021-05-05 Thread Joe Darcy
On Wed, 5 May 2021 18:53:50 GMT, Joe Darcy wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >> line 1769: >> >>> 1767: compiler.warn.strictfp=\ >>> 1768: as of release 17, all floating-point expressions are evaluated >>> strictly and ''strictfp'' i

Re: RFR: 8244146: javac changes for JEP 306 [v3]

2021-05-05 Thread Joe Darcy
> 8244146: javac changes for JEP 306 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3831/files - new: https://git.openjdk.java.

Re: RFR: 8244146: javac changes for JEP 306 [v2]

2021-05-05 Thread Joe Darcy
On Wed, 5 May 2021 05:31:40 GMT, Srikanth Adayapalam wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties >

Re: RFR: 8244146: javac changes for JEP 306 [v2]

2021-05-05 Thread Naoto Sato
On Wed, 5 May 2021 17:56:09 GMT, Joe Darcy wrote: >> 8244146: javac changes for JEP 306 > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. src/jdk.compiler/share/classes/com

Re: RFR: 8244146: javac changes for JEP 306 [v2]

2021-05-05 Thread Joe Darcy
> 8244146: javac changes for JEP 306 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.java.net/jdk/pull/3831/files - new: https://git.openjdk.java.

Re: RFR: 8244146: javac changes for JEP 306 [v2]

2021-05-05 Thread Brian Burkhalter
On Wed, 5 May 2021 17:53:43 GMT, Joe Darcy wrote: >> 8244146: javac changes for JEP 306 > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Changes to `java.base` look fine. The

Re: RFR: 8244146: javac changes for JEP 306

2021-05-05 Thread Joe Darcy
On Wed, 5 May 2021 06:07:23 GMT, Srikanth Adayapalam wrote: >> 8244146: javac changes for JEP 306 > > test/langtools/tools/javac/annotations/typeAnnotations/classfile/NestedLambdasCastedTest.java > line 34: > >> 32: * @build toolbox.ToolBox toolbox.JavapTask >>

Re: RFR: 8244146: javac changes for JEP 306

2021-05-05 Thread Jan Lahoda
On Wed, 5 May 2021 05:26:47 GMT, Srikanth Adayapalam wrote: >> 8244146: javac changes for JEP 306 > > src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line > 1704: > >> 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source)) >

Re: RFR: 8244146: javac changes for JEP 306

2021-05-05 Thread Jan Lahoda
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java line 170: > 168: > 169: allOptions.add("--should-stop=at=FLOW"); > 170: allOptions.add("-Xlint:unchecke

Re: RFR: 8244146: javac changes for JEP 306

2021-05-05 Thread Srikanth Adayapalam
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 Overall, looks good other than the various minor issues called out. I wonder if the tests would have turned out to be a good bit simpler if we simply checked diagnostics against a golden file and skip

Re: RFR: 8244146: javac changes for JEP 306

2021-05-04 Thread Srikanth Adayapalam
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 1326: > 1324: private void warnOnExplicitStrictfp(DiagnosticPosition pos, JCTree > tree) { > 1325: Diagno

Re: RFR: 8244146: javac changes for JEP 306

2021-05-04 Thread Joe Darcy
On 5/4/2021 10:30 PM, Srikanth Adayapalam wrote: On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 1704: 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source

Re: RFR: 8244146: javac changes for JEP 306

2021-05-04 Thread Srikanth Adayapalam
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 228: > 226: SEALED_CLASSES(JDK17, Fragments.FeatureSealedClasses, > DiagKind.PLURAL), > 227: // todo:

Re: RFR: 8244146: javac changes for JEP 306

2021-05-04 Thread Srikanth Adayapalam
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties line 1769: > 1767: compiler.warn.strictfp=\ > 1768: as of release 17, all floating-point expressions are

Re: RFR: 8244146: javac changes for JEP 306

2021-05-04 Thread Srikanth Adayapalam
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java line 1704: > 1702: if (Feature.REDUNDANT_STRICTFP.allowedInSource(source)) > 1703: result = result &a

Re: RFR: 8244146: javac changes for JEP 306

2021-05-04 Thread Joe Darcy
On Sat, 1 May 2021 23:00:05 GMT, Joe Darcy wrote: > 8244146: javac changes for JEP 306 For core-libs, under JEP 306 strictfp would be a no-op under 17. Therefore, the few uses of the strictfp modifier in the base module can be removed. - PR: https://git.openjdk.java.net/jdk/p

JEP 306 Question

2018-05-09 Thread A Z
Does anyone know what is going to be decided around full target status of JEP 306? I have been recommended to this list for the sake of this question. ? http://openjdk.java.net/jeps/306 https://bugs.openjdk.java.net/browse/JDK-8175916

Re: JEP 306

2018-05-09 Thread coleen . phillimore
This seems like better mailing list for this inquiry. Coleen On 5/9/18 6:43 AM, A Z wrote: Does anyone know what is going to be decided around full target status of JEP 306? I have been recommended to this list for the sake of this question. ? http://openjdk.java.net/jeps/306 https

Re: Fw: Question about JEP 306.

2017-12-06 Thread joe darcy
PS With a more concrete example below On 12/5/2017 6:55 PM, Joseph D. Darcy wrote: Hello, On 12/5/2017 5:07 PM, David Holmes wrote: Adding core-libs-dev as both mailing lists are named in this JEP. [snip] It should also be the case that there should be a round half up for the decima

Re: Fw: Question about JEP 306.

2017-12-05 Thread Joseph D. Darcy
Hello, On 12/5/2017 5:07 PM, David Holmes wrote: Adding core-libs-dev as both mailing lists are named in this JEP. David On 6/12/2017 11:02 AM, A Z wrote: -I have been wondering what interest, focus or progress is happening around OpenJDK JEP 306: The rampdown phase for JDK 10 is

Re: Fw: Question about JEP 306.

2017-12-05 Thread David Holmes
Adding core-libs-dev as both mailing lists are named in this JEP. David On 6/12/2017 11:02 AM, A Z wrote: -I have been wondering what interest, focus or progress is happening around OpenJDK JEP 306: http://openjdk.java.net/jeps/306 -As a Java feature request, could I request feature 306

JEP 306: Restore Always-Strict Floating-Point Semantics

2017-07-26 Thread mark . reinhold
New JEP Candidate: http://openjdk.java.net/jeps/306 - Mark