Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-09 Thread Brian Burkhalter
I've updated the webrev http://cr.openjdk.java.net/~bpb/6480539/ with all suggested changes. The javadoc change (CCC request) was approved. Thanks, Brian

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-09 Thread Joe Darcy
On 07/09/2013 11:46 AM, Brian Burkhalter wrote: I've updated the webrev http://cr.openjdk.java.net/~bpb/6480539/ with all suggested changes. The javadoc change (CCC request) was approved. Thanks, Brian If the specification change [...] If 2596 * {@code

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-09 Thread Brian Burkhalter
On Jul 9, 2013, at 12:17 PM, Joe Darcy wrote: If the specification change [...] If 2596 * {@code compareMagnitude(BigDecimal.ZERO) == 0}, then 2597 * {@code BigDecimal.ZERO} is returned. is modified to something like If this BigDecimal is numerically equal to

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-09 Thread Joseph Darcy
On 7/9/2013 12:46 PM, Brian Burkhalter wrote: On Jul 9, 2013, at 12:17 PM, Joe Darcy wrote: If the specification change [...] If 2596 * {@code compareMagnitude(BigDecimal.ZERO) == 0}, then 2597 * {@code BigDecimal.ZERO} is returned. is modified to something like If

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-04 Thread Stephen Colebourne
Just to note that I am supportive of this bug fix (compared to the previous proposal) Stephen On 3 July 2013 19:09, Brian Burkhalter brian.burkhal...@oracle.com wrote: On Jul 3, 2013, at 10:47 AM, Brian Burkhalter wrote: I'll update this only to change the one public method and to modify its

Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-03 Thread Brian Burkhalter
Hello, The patch here http://cr.openjdk.java.net/~bpb/6480539/ is proposed to resolve this issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6480539 which was most recently discussed in this thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-February/014252.html The

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-03 Thread Joe Darcy
Hi Brian, I have some concerns with this patch. First, I think the stripTrailingZeros specification should explicitly call out what happens with a numerically zero value. Second, I would have expected the code change to be limited to the stripTrailingZeros method. The private

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-03 Thread Brian Burkhalter
Hi Joe, Thanks for pointing out the problems with modifying the private methods. I'll update this only to change the one public method and to modify its specification. Thanks, Brian On Jul 3, 2013, at 10:35 AM, Joe Darcy wrote: I have some concerns with this patch. First, I think the

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-03 Thread Brian Burkhalter
On Jul 3, 2013, at 10:47 AM, Brian Burkhalter wrote: I'll update this only to change the one public method and to modify its specification. I've updated the webrev http://cr.openjdk.java.net/~bpb/6480539/ and rerun JTREG as well as modifying and resubmitting the CCC request (it had been

Re: Java 8 RFR 6480539: BigDecimal.stripTrailingZeros() has no effect on zero itself (0.0)

2013-07-03 Thread Joe Darcy
On 07/03/2013 11:09 AM, Brian Burkhalter wrote: On Jul 3, 2013, at 10:47 AM, Brian Burkhalter wrote: I'll update this only to change the one public method and to modify its specification. I've updated the webrev http://cr.openjdk.java.net/~bpb/6480539/ and rerun JTREG as well as modifying