Re: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors

2013-03-15 Thread Kumar Srinivasan
I concur too, I will chat with the Objectweb folks and see what needs to be done. Kumar - Original Message - On 14/03/2013 14:03, A. Sundararajan wrote: Please review http://cr.openjdk.java.net/~sundar/8010083/ Thanks -Sundar This looks okay to me but do we want to be changing the A

Re: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors

2013-03-14 Thread Andrew Hughes
- Original Message - > On 14/03/2013 14:03, A. Sundararajan wrote: > > Please review http://cr.openjdk.java.net/~sundar/8010083/ > > > > Thanks > > -Sundar > This looks okay to me but do we want to be changing the ASM source? > It > has a few compiler warnings too. Maybe Rémi or someone clo

Re: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors

2013-03-14 Thread Alan Bateman
On 14/03/2013 14:03, A. Sundararajan wrote: Please review http://cr.openjdk.java.net/~sundar/8010083/ Thanks -Sundar This looks okay to me but do we want to be changing the ASM source? It has a few compiler warnings too. Maybe Rémi or someone closer to ASM could get the issues fixed upstream (

Re: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors

2013-03-14 Thread Hannes Wallnoefer
Looks good to me. (Note that I'm not a core-libs reviewer though.) Hannes Am 2013-03-14 15:03, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8010083/ Thanks -Sundar

Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors

2013-03-14 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8010083/ Thanks -Sundar