On Fri, May 7, 2010 at 03:47, David Holmes wrote:
> Hi Chris,
>
> Chris Hegarty said the following on 05/07/10 19:55:
>>
>> Hi David, Martin,
>>
>> Thanks for filing the bug David, I'll just add a link to the email thread
>> in the archive for reference.
>
> Thanks.
>
>> Just one minor observation
On 07/05/2010 11:47, David Holmes wrote:
Hi Chris,
Chris Hegarty said the following on 05/07/10 19:55:
Hi David, Martin,
Thanks for filing the bug David, I'll just add a link to the email
thread in the archive for reference.
Thanks.
Just one minor observation while reviewing the changes. I
Hi Chris,
Chris Hegarty said the following on 05/07/10 19:55:
Hi David, Martin,
Thanks for filing the bug David, I'll just add a link to the email
thread in the archive for reference.
Thanks.
Just one minor observation while reviewing the changes. Is it necessary
for initFromPriorityQueue
Hi David, Martin,
Thanks for filing the bug David, I'll just add a link to the email
thread in the archive for reference.
Just one minor observation while reviewing the changes. Is it necessary
for initFromPriorityQueue to call initFromCollection ( in the case where
you're given a PriorityQu
Hi Martin,
CR 6950540 filed. (Chris might want to tidy it up :) )
Changes look okay to me.
Thanks,
David
Martin Buchholz said the following on 05/07/10 12:19:
David,
Of course you're right.
I didn't realize that the hole was one-element nulls.
(Why is software always 10 times harder than yo
David,
Of course you're right.
I didn't realize that the hole was one-element nulls.
(Why is software always 10 times harder than you'd think?)
Updated webrev, with lots more tests for corner cases.
I still need a bug filed in bugtraq.
Martin
On Thu, May 6, 2010 at 16:53, David Holmes wrote:
Hi Martin,
Martin Buchholz said the following on 05/07/10 09:13:
On Thu, May 6, 2010 at 15:58, David Holmes wrote:
Fix:
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/PriorityQueueConstructor/
I'm not sure this is necessarily the right fix. It seems to me that
incidental nulls will be c
On Thu, May 6, 2010 at 15:58, David Holmes wrote:
>> Fix:
>>
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/PriorityQueueConstructor/
>
> I'm not sure this is necessarily the right fix. It seems to me that
> incidental nulls will be caught in many/most cases by the sorting code for
> colle
Martin,
Martin Buchholz said the following on 05/07/10 08:24:
This is a bug report with fix.
(Chris, please file a bug)
Summary: PriorityQueue(collection) should throw NPE if collection
contains a null
Description:
PriorityQueue spec says:
"A priority queue does not permit {...@code
This is a bug report with fix.
(Chris, please file a bug)
Summary: PriorityQueue(collection) should throw NPE if collection
contains a null
Description:
PriorityQueue spec says:
"A priority queue does not permit {...@code null} elements."
but the constructor taking a collectio
10 matches
Mail list logo
