Stüfe ; Langer, Christoph
> >
> > Cc: Java Core Libs ; jdk-updates-
> > d...@openjdk.java.net; Baesken, Matthias
> > Subject: Re: [11u]: RFR: 8215281: Use String.isEmpty() when applicable in
> > java.base
> >
> > Hi,
> >
> >
> > On 2019-06-
HI Claes,
On Mon, Jun 24, 2019 at 10:22 AM Claes Redestad
wrote:
> Hi,
>
>
> On 2019-06-24 09:27, Thomas Stüfe wrote:
> > However, your patch (and the original one) contained the following part I
> > do not understand:
> >
> >
> http://cr.openjdk.java.net/~clanger/webrevs/8215281.11u/src/java.ba
all involved,
Christoph
> -Original Message-
> From: Claes Redestad
> Sent: Montag, 24. Juni 2019 10:24
> To: Thomas Stüfe ; Langer, Christoph
>
> Cc: Java Core Libs ; jdk-updates-
> d...@openjdk.java.net; Baesken, Matthias
> Subject: Re: [11u]: RFR: 8215281: U
Hi,
On 2019-06-24 09:27, Thomas Stüfe wrote:
However, your patch (and the original one) contained the following part I
do not understand:
http://cr.openjdk.java.net/~clanger/webrevs/8215281.11u/src/java.base/windows/classes/sun/nio/ch/FileDispatcherImpl.java.udiff.html
static boolean is
Hi Christoph,
I looked at the changes. Mostly good - true to the original change.
At various places
(e.g. src/java.base/share/classes/java/lang/ClassLoader.java) one could
remove the extra brackets, but since we want to keep the diff to head at a
minimum where possible I would not do this.
Howev
stoph
From: Baesken, Matthias
Sent: Dienstag, 18. Juni 2019 15:16
To: Langer, Christoph ;
jdk-updates-...@openjdk.java.net
Cc: Java Core Libs
Subject: RE: [11u]: RFR: 8215281: Use String.isEmpty() when applicable in
java.base
Hello Christoph, looks good with the exception of
src/java.base/
Hello Christoph, looks good with the exception of
src/java.base/share/classes/jdk/internal/module/Checks.java
http://cr.openjdk.java.net/~clanger/webrevs/8215281.11u/src/java.base/share/classes/jdk/internal/module/Checks.java.frames.html
/**
- * Returns {@code true} if the given n
