RE: [13] RFR: 8226876: Assertion in sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960

2019-06-27 Thread Langer, Christoph
Sounds great. Thank you. > -Original Message- > From: naoto.s...@oracle.com > Sent: Donnerstag, 27. Juni 2019 23:16 > To: Langer, Christoph ; i18n- > d...@openjdk.java.net; core-libs-dev > Subject: Re: [13] RFR: 8226876: Assertion in > sun/util/locale/provider/C

Re: [13] RFR: 8226876: Assertion in sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960

2019-06-27 Thread naoto . sato
Thanks for the review, Christoph. I'll wait for a whole day so that everyone sees the fix. Planning to push it tomorrow. Naoto On 6/27/19 2:05 PM, Langer, Christoph wrote: The change looks good to me. But I would say the assertion in CalendarDataUtility in line 266 is pointless now, isn't i

RE: [13] RFR: 8226876: Assertion in sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960

2019-06-27 Thread Langer, Christoph
> > The change looks good to me. But I would say the assertion in > CalendarDataUtility in line 266 is pointless now, isn't it? > > Yes, but would not hurt leaving it. It would catch error if yet another > case is installed (and it forgot to provide a default value) in the > switch statement. So I

Re: [13] RFR: 8226876: Assertion in sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960

2019-06-27 Thread naoto . sato
On 6/27/19 1:52 PM, Langer, Christoph wrote: Hi Naoto, thanks for providing a fix so quickly. The change looks good to me. But I would say the assertion in CalendarDataUtility in line 266 is pointless now, isn't it? Yes, but would not hurt leaving it. It would catch error if yet another cas

RE: [13] RFR: 8226876: Assertion in sun/util/locale/provider/CalendarDataUtility on Windows after JDK-8218960

2019-06-27 Thread Langer, Christoph
Hi Naoto, thanks for providing a fix so quickly. The change looks good to me. But I would say the assertion in CalendarDataUtility in line 266 is pointless now, isn't it? Best regards Christoph > -Original Message- > From: i18n-dev On Behalf Of > naoto.s...@oracle.com > Sent: Donnerst