Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Mandy Chung
On 2/21/2013 12:01 PM, Alan Bateman wrote: A minor note - the list of known jar files seems to be incomplete (e.g. tzdb.jar and some windows-specific ones). I think it may be better to file a bug to follow up this and maybe even better to replace the hardcoded list with other mechanism (if

Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Alan Bateman
On 21/02/2013 19:45, Mandy Chung wrote: Alan, This fix looks good and the "## fast path ..." comment can be taken out as Chris pointed out. Yes, I put that comment in there as a reminder and should have removed it - thanks (and Chris). A minor note - the list of known jar files seems to be

Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Mandy Chung
Alan, This fix looks good and the "## fast path ..." comment can be taken out as Chris pointed out. A minor note - the list of known jar files seems to be incomplete (e.g. tzdb.jar and some windows-specific ones). I think it may be better to file a bug to follow up this and maybe even bette

Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Alan Bateman
On 21/02/2013 16:42, Iris Clark wrote: Hi, Alan. Very nice. Just curious. How are you testing startup? Custom micro benchmark or are you using something else? A calendar :-) I'm using a performance test suite from the Oracle performance team. It's called refworkload and includes startup an

RE: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Iris Clark
Hi, Alan. Very nice. Just curious. How are you testing startup? Custom micro benchmark or are you using something else? iris -Original Message- From: Alan Bateman Sent: Thursday, February 21, 2013 6:33 AM To: core-libs-dev Subject: 8008290: (profiles) Startup regression due to addit

Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Chris Hegarty
On 21/02/2013 16:11, Lance Andersen - Oracle wrote: Alan, the changes look good and glad you added the extra comments for clarity. +1 Trivially, I think you can remove the comment: * ## Add a fast path like Class-Path to avoid reading the manifest when the attribute *is not present

Re: 8008290: (profiles) Startup regression due to additional checking of JAR file manifests

2013-02-21 Thread Lance Andersen - Oracle
Alan, the changes look good and glad you added the extra comments for clarity. Best Lance On Feb 21, 2013, at 9:33 AM, Alan Bateman wrote: > > This one is a startup-time regression caused by the compact profiles work. > > As background, there was a lot of work done in the distant past on start