Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

On 01/05/2019 21:48, Joe Darcy wrote: I'd prefer to push a version without the explicit map variable, but the max line length is slightly longer:   * - *   Map env = new HashMap<>(); - *   env.put("capacity", "16G"); - *   env.put("blockSize", "4k"); - *   F

Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

On 5/1/2019 11:43 AM, Alan Bateman wrote: On 01/05/2019 17:53, Joe Darcy wrote: : Keeping env to one line also gives a comparably long line length: --- a/src/java.base/share/classes/java/nio/file/FileSystems.java Tue Apr 30 16:11:42 2019 -0700 +++ b/src/java.base/share/classes/java/nio/file

Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

On 01/05/2019 17:53, Joe Darcy wrote: : Keeping env to one line also gives a comparably long line length: --- a/src/java.base/share/classes/java/nio/file/FileSystems.java Tue Apr 30 16:11:42 2019 -0700 +++ b/src/java.base/share/classes/java/nio/file/FileSystems.java Wed May 01 09:50:15 201

Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

> On May 1, 2019, at 9:53 AM, Joe Darcy wrote: > > --- a/src/java.base/share/classes/java/nio/file/FileSystems.java Tue Apr 30 > 16:11:42 2019 -0700 > +++ b/src/java.base/share/classes/java/nio/file/FileSystems.java Wed May 01 > 00:12:25 2019 -0700 > @@ -252,10 +252,9 @@ > * Suppose the

Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

Hi Alan, The maximum line length is actually slightly reduced by the proposed patch: --- a/src/java.base/share/classes/java/nio/file/FileSystems.java Tue Apr 30 16:11:42 2019 -0700 +++ b/src/java.base/share/classes/java/nio/file/FileSystems.java Wed May 01 00:12:25 2019 -0700 @@ -252,10 +252,

RE: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

> -Original Message- > From: core-libs-dev On Behalf > Of Alan Bateman > Sent: Mittwoch, 1. Mai 2019 08:17 > To: Joe Darcy ; nio-dev d...@openjdk.java.net> > Cc: core-libs-dev > Subject: Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem > examp

Re: JDK 13 RFR of JDK-8223178: Improve FileSystems.newFileSystem example with map factory methods

On 01/05/2019 02:59, Joe Darcy wrote: : --- a/src/java.base/share/classes/java/nio/file/FileSystems.java Tue Apr 30 16:11:42 2019 -0700 +++ b/src/java.base/share/classes/java/nio/file/FileSystems.java Tue Apr 30 18:52:11 2019 -0700 @@ -252,10 +252,9 @@   * Suppose there is a provider iden