Sorry this slipped through the cracks.
Looks good to me. (Don't know if you already pushed it :) )
David
On 25/04/2013 5:16 PM, Joe Darcy wrote:
Hello,
Responding to David's comment and some comments from Alan off-list, here
is a variant which doesn't use suppressed exceptions in initCause, b
racle.com; alan.bate...@oracle.com
> Subject: Re: REASSERT Code review request for 8012044: Give more information
> about self-suppression from Throwable.addSuppressed
> CC: core-libs-dev@openjdk.java.net
>
> Hello,
>
> Responding to David's comment and some comments from Alan
On 25/04/2013 08:16, Joe Darcy wrote:
Hello,
Responding to David's comment and some comments from Alan off-list,
here is a variant which doesn't use suppressed exceptions in
initCause, but still passes along some information:
http://cr.openjdk.java.net/~darcy/8012044.4
This looks reason
Hello,
Responding to David's comment and some comments from Alan off-list, here
is a variant which doesn't use suppressed exceptions in initCause, but
still passes along some information:
http://cr.openjdk.java.net/~darcy/8012044.4
Patch to Throwable:
--- a/src/share/classes/java/lang/T
> I still find the use of addSuppressed in initCause to be questionable.
> Given:
>
> catch(SomeException s) {
>sharedException.initCause(s); // oops already has a cause
> throw sharedException;
> }
>
> then the ISE isn't suppressing 's', but replacing/suppressing
> sharedException in m
On 04/23/2013 07:51 AM, Joe Darcy wrote:
Hi David,
On 04/22/2013 10:25 PM, David Holmes wrote:
Hi Joe,
On 23/04/2013 9:05 AM, Joseph Darcy wrote:
Hello,
Just reasserting the request for a review of the latest version of this
patch:
http://cr.openjdk.java.net/~darcy/8012044.2
I believe
Hi David,
On 04/22/2013 10:25 PM, David Holmes wrote:
Hi Joe,
On 23/04/2013 9:05 AM, Joseph Darcy wrote:
Hello,
Just reasserting the request for a review of the latest version of this
patch:
http://cr.openjdk.java.net/~darcy/8012044.2
I believe this version does an appropriate job of p
Hi Joe,
On 23/04/2013 9:05 AM, Joseph Darcy wrote:
Hello,
Just reasserting the request for a review of the latest version of this
patch:
http://cr.openjdk.java.net/~darcy/8012044.2
I believe this version does an appropriate job of propagating exception
information when there is misuse of
Hello,
Just reasserting the request for a review of the latest version of this
patch:
http://cr.openjdk.java.net/~darcy/8012044.2
I believe this version does an appropriate job of propagating exception
information when there is misuse of the methods on Throwable.
Thanks,
-Joe
On 4/17
