Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

2019-12-20 Thread Vladimir Kozlov
Subject: Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64 We missed AOT and JVMCI (in HS) changes similar for Base64 [1] to record StubRoutines pointers: StubRoutines::_bigIntegerRightShiftWorker StubRoutines::_bigIntegerLeftShiftWorker Smita>>>done

Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

2019-12-20 Thread Vladimir Kozlov
, December 19, 2019 5:17 PM To: Kamath, Smita Cc: Viswanathan, Sandhya ; 'hotspot compiler' Subject: Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64 We missed AOT and JVMCI (in HS) changes similar for Base64 [1] to record StubRoutines pointers: S

Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

2019-12-20 Thread Vladimir Kozlov
; 'hotspot compiler' Subject: Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64 We missed AOT and JVMCI (in HS) changes similar for Base64 [1] to record StubRoutines pointers: StubRoutines::_bigIntegerRightShiftWorker StubRoutines::_bigIntegerLeftShif

RE: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

2019-12-23 Thread Kamath, Smita
ations ( please look at the email below). >>> Link to the updated webrev: >>> https://cr.openjdk.java.net/~svkamath/bigIntegerShift/webrev02/ >>> >>> Regards, >>> Smita >>> >>> -----Original Message- >>> From: Vladimir Kozlov >>&

Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

2019-12-28 Thread Alan Bateman
On 20/12/2019 22:19, Vladimir Kozlov wrote: We should have added core-libs to review since you modified BigInteger.java. This adds Objects.checkFromToIndex checks in the middle of several supporting methods. Is IOOBE really possible in these cases or are these stand in for always-on asserts t

RE: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

2020-01-08 Thread Kamath, Smita
, Smita Cc: core-libs-dev@openjdk.java.net; 'hotspot compiler' Subject: Re: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64 On 20/12/2019 22:19, Vladimir Kozlov wrote: > We should have added core-libs to review since you modified > BigInteger.j