Looks good, thank you!
With kind regards,
Ivan
On 3/24/19 1:26 PM, Langer, Christoph wrote:
Hi Ivan,
thanks for looking closely.
UnixFileSystem_md.c:
Should the second error message be "Could not close file"?
Yes, maybe that's better. Though it's really just the fallback, one could at
leas
__
> Von: core-libs-dev im Auftrag
> von Alan Bateman
> Gesendet: Freitag, März 22, 2019 5:35 PM
> An: Langer, Christoph; Java Core Libs
> Betreff: Re: RFR(S): 8221262: Cleanups in UnixFileSystem/WinNTFileSystem
> implementation classes
&g
Hi Ivan,
thanks for looking closely.
> UnixFileSystem_md.c:
> Should the second error message be "Could not close file"?
Yes, maybe that's better. Though it's really just the fallback, one could at
least distinguish the two possibilities of IOException in this method...
> UnixFileSystem.java:
Hi Christoph!
UnixFileSystem_md.c:
Should the second error message be "Could not *close* file"?
UnixFileSystem.java:
Line spacing looks inconsistent. Please leave an empty line before
@Override at lines 267, 269, 271, 273, etc.
With kind regards,
Ivan
On 3/22/19 1:37 AM, Langer, Christoph
:35 PM
An: Langer, Christoph; Java Core Libs
Betreff: Re: RFR(S): 8221262: Cleanups in UnixFileSystem/WinNTFileSystem
implementation classes
On 22/03/2019 08:37, Langer, Christoph wrote:
> Hi,
>
> when contemplating over JDK-8211752, I found a few minor cleanups for the
> implem
On 22/03/2019 08:37, Langer, Christoph wrote:
Hi,
when contemplating over JDK-8211752, I found a few minor cleanups for the
implementations of UnixFileSystem/WinNTFileSystem. Can I please get reviews?
Bug: https://bugs.openjdk.java.net/browse/JDK-8221262
Webrev: http://cr.openjdk.java.net/~cla
