On 10/14/2014 3:55 AM, Daniel Fuchs wrote:
http://cr.openjdk.java.net/~dfuchs/webrev_8059767/webrev.02
Looks good.
Nit: use {@code...} instead of It may be
inconsistent with the javadoc for other existing constructors
that I think it's good to clean up the new one at least.
No need to
Hi,
Following a feedback from Alan - I dropped 'SecurityException'
from the throws clause of the new constructor - keeping
only the @throws in the API documentation.
Here is the new webrev (the above is the only change compared
to the previous webrev.01).
http://cr.openjdk.java.net/~dfuchs/webr
On 08/10/14 08:26, Ivan Gerasimov wrote:
Hi Daniel!
Would it make sense to make the old constructor FileHandler(String,
*int*, int, boolean) call the new one, casting the limit to long?
Hi Ivan,
I was about to reply 'no' out of consistency with the other
constructors - which don't call each o
On 07/10/14 21:50, Jason Mehrens wrote:
Hi Daniel,
The only thing I noticed is a missing @since tag on the FileHandler.
Oops, thanks for catching that Jason.
-- daniel
Jason
Date: Tue, 7 Oct 2014 15:13:13 +0200
From: daniel.fu...@oracle.com
To:
Hi Daniel!
Would it make sense to make the old constructor FileHandler(String,
*int*, int, boolean) call the new one, casting the limit to long?
Sincerely yours,
Ivan
On 07.10.2014 17:13, Daniel Fuchs wrote:
Hi,
Please find below a patch for:
8059767: FileHandler should allow 'long' limits
Hi Daniel,
The only thing I noticed is a missing @since tag on the FileHandler.
Jason
> Date: Tue, 7 Oct 2014 15:13:13 +0200
> From: daniel.fu...@oracle.com
> To: core-libs-dev@openjdk.java.net
> Subject: RFR: 8059767: FileHandler should allow 'long' li
