RE: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

2018-05-11 Thread Langer, Christoph
t;christoph.lan...@sap.com><mailto:christoph.lan...@sap.com>; core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net> Subject: Re: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator Thanks for br

Re: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

2018-05-10 Thread Joe Wang
* Re: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator Thanks for bringing in what's been in SAP's JVM. The change looks good to me. On whether to remove the commented lines (the unused getContentSpecType method), I would s

RE: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

2018-05-10 Thread Langer, Christoph
before pushing, of course. Best regards Christoph From: Joe Wang [mailto:huizhe.w...@oracle.com] Sent: Donnerstag, 10. Mai 2018 20:08 To: Langer, Christoph <christoph.lan...@sap.com>; core-libs-dev@openjdk.java.net Subject: Re: RFR (S): 8202915: [JAXP] Performance enhancements and cl

Re: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

2018-05-10 Thread Joe Wang
Thanks for bringing in what's been in SAP's JVM. The change looks good to me. On whether to remove the commented lines (the unused getContentSpecType method), I would say yes since that was replaced with that of a DTDGrammar method a long long time ago :-) Cheers, Joe On 5/10/2018 9:01 AM,

RE: RFR (S): 8202915: [JAXP] Performance enhancements and cleanups in com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator

2018-05-10 Thread Langer, Christoph
One addition: I think it would be more appropriate to completely remove the commented lines but I didn't dare to do so yet. What do you think? From: Langer, Christoph Sent: Donnerstag, 10. Mai 2018 17:51 To: core-libs-dev@openjdk.java.net; 'Joe Wang' Subject: RFR (S):