Re: RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-25 Thread Xueming Shen
+1 A potential "enhancement" for future consideration is whether or not worth to combine DeflaterZFStreamRef/InflaterZFStream back to one class, maybe with a "instanceof" before calling Deflater/Inflater.end(addr). -Sherman On 10/24/18, 10:19 AM, Lance Andersen wrote: Hi all, This change remo

Re: RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-25 Thread Lance Andersen
> On Oct 25, 2018, at 9:32 AM, Alan Bateman wrote: > > > > On 24/10/2018 18:19, Lance Andersen wrote: >> Hi all, >> >> This change removes the finalize methods from >> java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecated and >> marked for removal in JDK 9 >> >> The web

Re: RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-25 Thread Alan Bateman
On 24/10/2018 18:19, Lance Andersen wrote: Hi all, This change removes the finalize methods from java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecated and marked for removal in JDK 9 The webrev can be found at: http://cr.openjdk.java.net/~lancea/8212129/webrev.00/

Re: RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-25 Thread Roger Riggs
Looks good Lance Thanks On 10/24/2018 01:19 PM, Lance Andersen wrote: Hi all, This change removes the finalize methods from java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecated and marked for removal in JDK 9 The webrev can be found at: http://cr.openjdk.java.net/~lancea

RE: RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-25 Thread Langer, Christoph
Hi Lance, looks fine, reviewed. Good to see this happening. Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Lance Andersen > Sent: Mittwoch, 24. Oktober 2018 19:20 > To: core-libs-dev > Subject: RFR 8212129: Remove finalize methods from > java.util.zip.