Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Thanks for joining the small club of zip implementers. No one likes the ZIP file format, but the power of a legacy data interchange format is great. On Wed, Aug 7, 2019 at 11:54 AM Lance Andersen wrote: > Hi Martin, > > On Aug 7, 2019, at 2:37 PM, Martin Buchholz wrote: > > Thanks for fixing th

Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Hi Martin, > On Aug 7, 2019, at 2:37 PM, Martin Buchholz wrote: > > Thanks for fixing this. Looks good. Thank you. > The APPNOTE.TXT spec is very confusing and surprising - it is not at all > obvious why the size fields are required in the LOC ZIP64 header but not in > the CEN ZIP64 header.

Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Thanks for fixing this. Looks good. The APPNOTE.TXT spec is very confusing and surprising - it is not at all obvious why the size fields are required in the LOC ZIP64 header but not in the CEN ZIP64 header. I might include a reference to the sections in the PKWARE spec - 4.5.3 and 4.4.9 It seems t

Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Hi Lance, > On Aug 7, 2019, at 9:33 AM, Lance Andersen wrote: > > I thought about it but decided it was not needed at least now given the files > are only used by this test and the scratch directory will get cleaned up > anyways. I thought that might be the case. > If you think I should add

Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Hi Brian, > On Aug 7, 2019, at 12:21 PM, Brian Burkhalter > wrote: > > Hi Lance, > > Looks good. thank you > I was wondering whether you might want to delete the files using > jdk.test.lib.util.FileUtils.deleteFileIfExistsWithRetry() instead. I thought about it but decided it was not needed

Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Hi Lance, Looks good. I was wondering whether you might want to delete the files using jdk.test.lib.util.FileUtils.deleteFileIfExistsWithRetry() instead. Brian > On Aug 6, 2019, at 1:31 PM, Lance Andersen wrote: > > Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8226530 >

Re: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

On 8/6/19 10:31 PM, Lance Andersen wrote: > The webrev can be found at > http://cr.openjdk.java.net/~lancea/8226530/webrev.00/index.html Looks good to me. I spot-tested my test cases that used to fail, and they all pass with this patch. Thanks! -Aleksey

RE: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries

Hi Lance, this looks good to me. Best regards Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Lance Andersen > Sent: Dienstag, 6. August 2019 22:32 > To: core-libs-dev > Subject: RFR 8226530: ZipFile reads wrong entry size from ZIP64 entries > > Hi > > Please revi