Re: RFR(JDK 12/java.xml) 8213734: SAXParser.parse(File, ..) does not close resources when Exception occurs.

Looks OK Joe! > On Nov 29, 2018, at 3:25 PM, Joe Wang wrote: > > Thanks Lance. Changed the for loop to a while loop: > > http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_02/ > > previous: > http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_01/ > > -Joe > > On 11/29/18, 11:17 AM,

Re: RFR(JDK 12/java.xml) 8213734: SAXParser.parse(File, ..) does not close resources when Exception occurs.

Thanks Lance. Changed the for loop to a while loop: http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_02/ previous: http://cr.openjdk.java.net/~joehw/jdk12/8213734/webrev_01/ -Joe On 11/29/18, 11:17 AM, Joe Wang wrote: Hi, Please review a fix for the issue as reported that the SAXParser

RFR(JDK 12/java.xml) 8213734: SAXParser.parse(File, ..) does not close resources when Exception occurs.

Hi, Please review a fix for the issue as reported that the SAXParser does not close the underlying reader. This code always existed in Xerces, but it was somehow removed as the comment for the closeReaders method showed. The comment stated "readers are closed in the endEntity method", that is