Re: RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

2019-02-05 Thread Joe Wang
Thanks, Lance and Roger! The changeset is pushed now. Best, Joe On 2/5/19, 11:52 AM, Lance Andersen wrote: Hi Joe, The change seems reasonable... On Feb 5, 2019, at 1:37 PM, Joe Wang > wrote: Please review a quick fix for preserving the initial state of the T

Re: RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

2019-02-05 Thread Lance Andersen
Hi Joe, The change seems reasonable... > On Feb 5, 2019, at 1:37 PM, Joe Wang wrote: > > Please review a quick fix for preserving the initial state of the > Transformer. The faulty impl passes a reference of the initial property > setting to the working copy during reset, thus causes it to be

Re: RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

2019-02-05 Thread Roger Riggs
Looks good. Thanks, Roger On 02/05/2019 01:37 PM, Joe Wang wrote: Please review a quick fix for preserving the initial state of the Transformer. The faulty impl passes a reference of the initial property setting to the working copy during reset, thus causes it to be altered by an user setting

RFR(JDK 13/java.xml) 8180901: Transformer.reset() resets the state only once

2019-02-05 Thread Joe Wang
Please review a quick fix for preserving the initial state of the Transformer. The faulty impl passes a reference of the initial property setting to the working copy during reset, thus causes it to be altered by an user setting. Further reset would then no longer be able to return to the initia