Re: RFR(JDK 13/java.xml) 8187697: Cleanup: irrelevant code in OutputPropertiesFactory

2019-02-13 Thread Joe Wang
On 2/13/19, 11:55 AM, Lance Andersen wrote: Hi Joe Overall the change seems Ok, assuming all the tests are happy :-) Yes, they all are happy. One minor suggestion for: src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java - line 150, plea

Re: RFR(JDK 13/java.xml) 8187697: Cleanup: irrelevant code in OutputPropertiesFactory

2019-02-13 Thread Lance Andersen
Hi Joe Overall the change seems Ok, assuming all the tests are happy :-) One minor suggestion for: src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java - line 150, please put the ‘*/“ on its own line > On Feb 13, 2019, at 1:15 PM, Joe Wang wro

RFR(JDK 13/java.xml) 8187697: Cleanup: irrelevant code in OutputPropertiesFactory

2019-02-13 Thread Joe Wang
Please review a cleanup patch for the OutputPropertiesFactory. The original intention was to remove the (awkward) JDK 1.2-related code, line 235-258 in the old file. I then went a bit further to remove another nuisance that annoyed users with an error "Could not load the property file 'output