Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Thanks Lance! -Joe On 7/2/19, 10:22 AM, Lance Andersen wrote: Looks OK to me Joe On Jul 2, 2019, at 11:51 AM, Joe Wang > wrote: Thanks Daniel. That test case is added. Best, Joe On 7/2/19, 1:21 AM, Daniel Fuchs wrote: Hi Joe, I haven't spotted anything

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Looks OK to me Joe > On Jul 2, 2019, at 11:51 AM, Joe Wang wrote: > > Thanks Daniel. That test case is added. > > Best, > Joe > > On 7/2/19, 1:21 AM, Daniel Fuchs wrote: >> Hi Joe, >> >> I haven't spotted anything obviously wrong. >> >>> The content of "abcxyz" should be "abc & xyz", not "

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Thanks Daniel! On 7/2/19, 9:16 AM, Daniel Fuchs wrote: Hi Joe, On 02/07/2019 17:51, Joe Wang wrote: Thanks Daniel. That test case is added. LGTM! best regards, -- daniel Best, Joe On 7/2/19, 1:21 AM, Daniel Fuchs wrote: Hi Joe, I haven't spotted anything obviously wrong. The

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Hi Joe, On 02/07/2019 17:51, Joe Wang wrote: Thanks Daniel. That test case is added. LGTM! best regards, -- daniel Best, Joe On 7/2/19, 1:21 AM, Daniel Fuchs wrote: Hi Joe, I haven't spotted anything obviously wrong. The content of "abcxyz" should be "abc & xyz", not "    abc\n & \n 

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

On 7/2/19, 1:23 AM, Daniel Fuchs wrote: Oh, and BTW is the change to PrettyPrintTest.java intended? (the removal of the line: 385 dbf.setValidating(true); seems to be the only change) Yes. The only effect of setting validating without an ErrorHandler was producing lots of warnings

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Thanks Daniel. That test case is added. Best, Joe On 7/2/19, 1:21 AM, Daniel Fuchs wrote: Hi Joe, I haven't spotted anything obviously wrong. The content of "abcxyz" should be "abc & xyz", not "abc\n & \nxyz\n" as that before this fix. Maybe the test could have a test case for

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Oh, and BTW is the change to PrettyPrintTest.java intended? (the removal of the line: 385 dbf.setValidating(true); seems to be the only change) best regards, -- daniel On 02/07/2019 10:21, Daniel Fuchs wrote: JBS: https://bugs.openjdk.java.net/browse/JDK-8223291 webrev:

Re: RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Hi Joe, I haven't spotted anything obviously wrong. The content of "abcxyz" should be "abc & xyz", not "abc\n & \nxyz\n" as that before this fix. Maybe the test could have a test case for that specific example too? Just to make sure whitespaces in CDATA aren't eaten away? best

RFR(JDK 14/java.xml) 8223291: Whitespace is added to CDATA tags when using OutputKeys.INDENT to format XML

Please review a fix to xml pretty print. This is a regression introduced during the JDK 9 development. CDATA is marked up to be interpreted literally as textual data, in other words, it's still character data. The processor therefore shall treat it as text data. The content of "abcxyz" should