Re: RFR(JDK12/NIO) 8209576: java.nio.file.Files.writeString writes garbled UTF-16 instead of UTF-8

2018-08-20 Thread Joe Wang
Thanks Sherman! All tests in core were passed. The patch is now pushed. -Joe On 8/17/18, 2:49 PM, Xueming Shen wrote: +1 On 08/17/2018 02:39 PM, Joe Wang wrote: Hi, Please review a fix for a condition where a code conversion was skipped incorrectly resulting in a wrong byte array being wri

Re: RFR(JDK12/NIO) 8209576: java.nio.file.Files.writeString writes garbled UTF-16 instead of UTF-8

2018-08-17 Thread Xueming Shen
+1 On 08/17/2018 02:39 PM, Joe Wang wrote: Hi, Please review a fix for a condition where a code conversion was skipped incorrectly resulting in a wrong byte array being written into the file. JBS: https://bugs.openjdk.java.net/browse/JDK-8209576 webrevs: http://cr.openjdk.java.net/~joehw/jdk1

RFR(JDK12/NIO) 8209576: java.nio.file.Files.writeString writes garbled UTF-16 instead of UTF-8

2018-08-17 Thread Joe Wang
Hi, Please review a fix for a condition where a code conversion was skipped incorrectly resulting in a wrong byte array being written into the file. JBS: https://bugs.openjdk.java.net/browse/JDK-8209576 webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8209576/webrev/ Thanks, Joe