RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage): http://cr.openjdk.java.net/~simonis/webrevs/8031581/ I've build and smoke tested

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 14/01/2014 08:40, Volker Simonis wrote: Hi, could you please review the following changes for the ppc-aix-port stage/stage-9 repositories (the changes are planned for integration into ppc-aix-port/stage-9 and subsequent backporting to ppc-aix-port/stage): I'd like to review this but I won'

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Hi Alan, On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman wrote: > On 14/01/2014 08:40, Volker Simonis wrote: > >> Hi, >> >> could you please review the following changes for the ppc-aix-port >> stage/stage-9 repositories (the changes are planned for integration into >> ppc-aix-port/stage-9 and sub

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Just a note on this part (I havent looked at the code): On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...) are defined to different values than on other operating systems. The problem is however, that these constants are hardcoded as public final static members of v

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Tue, Jan 14, 2014 at 12:29 PM, David Holmes wrote: > Just a note on this part (I havent looked at the code): > > > On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, >> ...) are defined to different values than on other operating systems. The >> problem is however, that t

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 15/01/2014 12:10 AM, Volker Simonis wrote: On Tue, Jan 14, 2014 at 12:29 PM, David Holmes mailto:david.hol...@oracle.com>> wrote: Just a note on this part (I havent looked at the code): On AIX, the constants used for the polling events (i.e. POLLIN, POLLOUT, ...) are def

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Volker, I’ve look at the following files: src/share/native/sun/management/DiagnosticCommandImpl.c: nit: “legel” -> “legal” (two times) In Java_sun_management_DiagnosticCommandImpl_getDiagnosticCommandInfo() if you allow dcmd_info_array to become NULL, then jmm_interface->GetDiagnosticCommandInf

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 15/01/2014 06:24, David Holmes wrote: I'm not a fan of runtime checks of this kind though if it is only a very samll number of values it might be okay. Another option would be to make those classes into "templates" as done with Version.java.template and substitute the right values at buil

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 10:03 AM, Alan Bateman wrote: > On 15/01/2014 06:24, David Holmes wrote: > >> >> I'm not a fan of runtime checks of this kind though if it is only a very >> samll number of values it might be okay. >> >> Another option would be to make those classes into "templates" as done

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Hi Staffan, thanks for the review. Please find my comments inline: On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen wrote: > Volker, > > I’ve look at the following files: > > src/share/native/sun/management/DiagnosticCommandImpl.c: > nit: “legel” -> “legal” (two times) > In Java_sun_management_Di

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis wrote: > Hi Staffan, > > thanks for the review. Please find my comments inline: > > On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen > wrote: >> >> Volker, >> >> I’ve look at the following files: >> >> src/share/native/sun/management/DiagnosticComman

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis wrote: > On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis > wrote: >> Hi Staffan, >> >> thanks for the review. Please find my comments inline: >> >> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen < staffan.lar...@oracle.com> >> wrote: >>> >>> Volker

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

Yes, that looks like a good solution. /Staffan On 15 jan 2014, at 17:34, Volker Simonis wrote: > Hi Staffan, > > thanks for the review. Please find my comments inline: > > On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen > wrote: > Volker, > > I’ve look at the following files: > > src/shar

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 15 jan 2014, at 18:27, Volker Simonis wrote: > On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis > wrote: >> Hi Staffan, >> >> thanks for the review. Please find my comments inline: >> >> On Wed, Jan 15, 2014 at 9:57 AM, Staffan Larsen >> wrote: >>> >>> Volker, >>> >>> I’ve look at the fo

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 15 jan 2014, at 18:52, Volker Simonis wrote: > > > On Wed, Jan 15, 2014 at 6:27 PM, Volker Simonis > wrote: > > On Wed, Jan 15, 2014 at 5:34 PM, Volker Simonis > > wrote: > >> Hi Staffan, > >> > >> thanks for the review. Please find my comments inline: > >> > >> On Wed, Jan 15, 2014 at 9

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Wed, Jan 15, 2014 at 12:05 PM, Volker Simonis wrote: > > > > On Wed, Jan 15, 2014 at 10:03 AM, Alan Bateman wrote: > >> On 15/01/2014 06:24, David Holmes wrote: >> >>> >>> I'm not a fan of runtime checks of this kind though if it is only a very >>> samll number of values it might be okay. >>> >

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 16/01/2014 09:38, Volker Simonis wrote: Hi Alan, I think sun.nio.ch.IOUtil seems even more appropriate to me for these constants. What do you think? Would it be OK for you if I initialize them right in the static initializer of IOUtil based on "os.name " or do you pref

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Thu, Jan 16, 2014 at 11:05 AM, Alan Bateman wrote: > On 16/01/2014 09:38, Volker Simonis wrote: > > > > Hi Alan, > > I think sun.nio.ch.IOUtil seems even more appropriate to me for these > constants. What do you think? > > Would it be OK for you if I initialize them right in the static initiali

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 16/01/2014 10:34, Volker Simonis wrote: : I just thought because poll is more file-descriptor oriented and not network specific. And the constants are also used for example in: src/macosx/classes/sun/nio/ch/KQueueArrayWrapper.java: src/solaris/classes/sun/nio/ch/sctp/Sctp* src/solaris/classes

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman wrote: > On 14/01/2014 08:40, Volker Simonis wrote: >> >> Hi, >> >> could you please review the following changes for the ppc-aix-port >> stage/stage-9 repositories (the changes are planned for integration into >> ppc-aix-port/stage-9 and subsequent b

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Fri, Jan 17, 2014 at 10:15 PM, Volker Simonis wrote: > On Tue, Jan 14, 2014 at 10:19 AM, Alan Bateman > wrote: >> On 14/01/2014 08:40, Volker Simonis wrote: >>> >>> Hi, >>> >>> could you please review the following changes for the ppc-aix-port >>> stage/stage-9 repositories (the changes are p

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 20/01/2014 09:59, Volker Simonis wrote: : Hi Alan, yes, that's interesting. Sounds like a very similar problem on Mac. I would suggest the following: I cut out the "Async Close AIX FIX" stuff from this change (i.e. "8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests"

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Mon, Jan 20, 2014 at 12:41 PM, Alan Bateman wrote: > On 20/01/2014 09:59, Volker Simonis wrote: >> >> : >> Hi Alan, >> >> yes, that's interesting. Sounds like a very similar problem on Mac. >> >> I would suggest the following: >> >> I cut out the "Async Close AIX FIX" stuff from this change (i.

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 20/01/2014 13:45, Volker Simonis wrote: : Hi everybody, so here's the second version of this webrev: http://cr.openjdk.java.net/~simonis/webrevs/8031581_2/ This looks okay to me. The typo ("legel" -> "legal") still exists in zip_util.c and maybe that can be fixed before you push this (no

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On Mon, Jan 20, 2014 at 4:24 PM, Alan Bateman wrote: > On 20/01/2014 13:45, Volker Simonis wrote: >> >> : >> Hi everybody, >> >> so here's the second version of this webrev: >> >> http://cr.openjdk.java.net/~simonis/webrevs/8031581_2/ > > This looks okay to me. Thanks. > > The typo ("legel" -> "

Re: RFR(L): 8031581: PPC64: Addons and fixes for AIX to pass the jdk regression tests

On 20/01/2014 16:29, Volker Simonis wrote: : @Alan: on the other hand, the bulk integration from ppc-aix-port/stage-9 to jdk9/dev is planned for next week anyway, so maybe you could wait until that happens? In that case then ignore my request, I assumed it would not be pushed to jdk9/dev until