Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-27 Thread Brian Goetz
So from your (and Alan's and Lance's) point of view does it still make sense to create a JEP for this enhancement and have a broader discussion about its usefulness on the "discuss" list? Or is your rejection definitive, no matter what the outcome of such a discussion will be? I think it's

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-27 Thread Volker Simonis
Hi Brian, thanks a lot for your detailed answer. I've replied to some of your comments inline but I don't expect another answer because it seems that all arguments have been exchanged and we're happily agreeing to disagree :) There's just a single remaining question for which I would appreciate a

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-24 Thread Brian Goetz
On 7/24/2020 7:48 AM, Volker Simonis wrote: I think it's reasonable to ask if the JDK really needs to support this complexity. I can't see much complexity here. Then I think we should start there.   Until you can see the complexity here that is obvious to Alan, Lance, myself, and others, t

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-24 Thread Volker Simonis
On Fri, Jul 24, 2020 at 2:15 PM Alan Bateman wrote: > > > On 24/07/2020 12:48, Volker Simonis wrote: > > : > > > > I can't see much complexity here. If you look at the change you'll see > > that it's rather trivial. All it does is substituting some direct > > calls into the zlib library by indirec

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-24 Thread Alan Bateman
On 24/07/2020 12:48, Volker Simonis wrote: : I can't see much complexity here. If you look at the change you'll see that it's rather trivial. All it does is substituting some direct calls into the zlib library by indirect calls through function pointers. I don't think the JDK should be in the

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-24 Thread Volker Simonis
On Thu, Jul 23, 2020 at 8:48 PM Alan Bateman wrote: > > On 23/07/2020 18:18, Volker Simonis wrote: > > Hi, > > Hi Alan, thanks for promptly looking into my proposal. Please find my answers inline: > > can I please get some reviews for the following small enhancement > > which will allow you to

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-24 Thread Volker Simonis
On Thu, Jul 23, 2020 at 9:35 PM Lance Andersen wrote: > > Hi Volker, > Hi Lance, thanks for looking at my proposal. Please find my comments inline: > > A change such as this I believe would require a JEP to fully define the > changes/risks/benefits > The change itself is quite small and it doe

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-23 Thread Thomas Stüfe
Hi, Could this not be handled like any other third party provided binary which can run in our process? Say, a jvmti agent, any JNI library, or any system library? For all these cases we expect the user to know what he is doing, resp. the system library not to be buggy. Why not here? This seems lik

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-23 Thread Lance Andersen
Hi Volker, A change such as this I believe would require a JEP to fully define the changes/risks/benefits I do have concerns about using multiple implementations for compression/decompression. From a testing and support perspective, this adds additional burden. What type of testing matrix ar

Re: RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-23 Thread Alan Bateman
On 23/07/2020 18:18, Volker Simonis wrote: Hi, can I please get some reviews for the following small enhancement which will allow you to configure different zlib implementations at VM start-up and get up to 100% better throughput for compression and about 50% better throughput for decompression

RFR(M): 8249963: Make the zlib implementation selectively configurable at startup

2020-07-23 Thread Volker Simonis
Hi, can I please get some reviews for the following small enhancement which will allow you to configure different zlib implementations at VM start-up and get up to 100% better throughput for compression and about 50% better throughput for decompression (depending on the selected zlib implementatio