Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

2015-12-18 Thread Claes Redestad
Vladimir, Rémi and Michael, thanks for reviewing this! /Claes On 2015-12-18 16:58, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~redestad/8144723/webrev.02/ Looks good. Best regards, Vladimir Ivanov

Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

2015-12-18 Thread Vladimir Ivanov
http://cr.openjdk.java.net/~redestad/8144723/webrev.02/ Looks good. Best regards, Vladimir Ivanov

Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

2015-12-07 Thread Claes Redestad
Hi Remi, On 2015-12-07 12:42, Remi Forax wrote: Hi Claes, Makers should be declared 'private', so the constructor by default will be private. You should remove 'private' in front of TYPED_COLLECTORS, PRODUCE_BLOCK_INLINING_FORM and PRODUCE_REINVOKER_FORM because otherwise the compiler will g

Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

2015-12-07 Thread Remi Forax
Envoyé: Vendredi 4 Décembre 2015 17:28:04 > Objet: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed > > Hi, > > please review this issue to remove explicit initialization of > MethodHandleImpl, which doesn't seem to be needed after recent > j.l.invoke

Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

2015-12-07 Thread Michael Haupt
Hi Claes, this is a lower-case review, but thumbs up. Truth or dare. ;-) Best, Michael > Am 04.12.2015 um 17:28 schrieb Claes Redestad : > > Hi, > > please review this issue to remove explicit initialization of > MethodHandleImpl, which doesn't seem to be needed after recent j.l.invoke > bo

RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

2015-12-04 Thread Claes Redestad
Hi, please review this issue to remove explicit initialization of MethodHandleImpl, which doesn't seem to be needed after recent j.l.invoke bootstrap improvements. Bug: https://bugs.openjdk.java.net/browse/JDK-8144723 Webrev: http://cr.openjdk.java.net/~redestad/8144723/webrev.01/ This remov