On 26/04/2019 7:25 pm, Alan Bateman wrote:
On 26/04/2019 06:32, David Holmes wrote:
I pushed this today based on Dan and Robbin's reviews, but realized
just after the act that I should have waited for any feedback from
core-libs - apologies about that. If there are concerns I will roll it
back
On 26/04/2019 06:32, David Holmes wrote:
I pushed this today based on Dan and Robbin's reviews, but realized
just after the act that I should have waited for any feedback from
core-libs - apologies about that. If there are concerns I will roll it
back.
I don't think there are any concerns, it i
I'll file a RFE for that.
Great, thanks!
/Robbin
Thanks,
David
Thanks, Robbin
On 4/24/19 9:12 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222518
webrev: http://cr.openjdk.java.net/~dholmes/8222518/webrev/
The original implementation of Unsafe.unpark simply e
I pushed this today based on Dan and Robbin's reviews, but realized just
after the act that I should have waited for any feedback from core-libs
- apologies about that. If there are concerns I will roll it back.
Thanks,
David
-
On 26/04/2019 2:57 pm, David Holmes wrote:
Thanks Dan! Extran
Hi Robbin,
On 25/04/2019 5:53 pm, Robbin Ehn wrote:
Hi David,
Looks good.
Thanks for the review.
Just a question:
It seems like we could just hold the ThreadsList over p->unpark() and
not rely on TSM ?
Yes now it is done this way we could do the unpark while holding the TLH
and avoid re
Thanks Dan! Extraneous ; culled.
David
On 25/04/2019 1:16 am, Daniel D. Daugherty wrote:
On 4/24/19 3:12 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222518
webrev: http://cr.openjdk.java.net/~dholmes/8222518/webrev/
src/hotspot/share/classfile/javaClasses.cpp
Hi David,
Looks good.
Just a question:
It seems like we could just hold the ThreadsList over p->unpark() and not rely
on TSM ?
Not sure in how many places we do rely on it, but it would be nice to remove TSM
for parkers.
The exiting thread would set parker to NULL before removing itself from t
On 4/24/19 3:12 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222518
webrev: http://cr.openjdk.java.net/~dholmes/8222518/webrev/
src/hotspot/share/classfile/javaClasses.cpp
L1629: macro(_park_blocker_offset, k, "parkBlocker",
object_signature, false);
L
Bug: https://bugs.openjdk.java.net/browse/JDK-8222518
webrev: http://cr.openjdk.java.net/~dholmes/8222518/webrev/
The original implementation of Unsafe.unpark simply extracted the
JavaThread reference from the java.lang.Thread oop and if non-null
extracted the Parker instance from it and invoke
