Alan, Jaroslav, Dmitry: Thanks!
On 7 feb 2014, at 12:38, Jaroslav Bachorik wrote:
> Looks good. Additional benefit is the compliance with the secure coding guide.
>
> -JB-
>
> On February 7, 2014 11:46:07 AM CET, Staffan Larsen
> wrote:
> A few of the public read and write methods in FileInp
Looks good. Additional benefit is the compliance with the secure coding guide.
-JB-
On February 7, 2014 11:46:07 AM CET, Staffan Larsen
wrote:
>A few of the public read and write methods in FileInputStream and
>RandomAccessFile are declared native. This means that it is hard to
>instrument them
Staffan,
OK! Looks good for me.
-Dmitry
On 2014-02-07 15:28, Staffan Larsen wrote:
> I would prefer that to be a different change.
>
> Thanks,
> /Staffan
>
> On 7 feb 2014, at 12:07, Dmitry Samersoff wrote:
>
>> Staffan,
>>
>> As far as you touching this.
>>
>> Is it possible to change all n
On 7 feb 2014, at 11:56, Alan Bateman wrote:
> On 07/02/2014 10:46, Staffan Larsen wrote:
>> A few of the public read and write methods in FileInputStream and
>> RandomAccessFile are declared native. This means that it is hard to
>> instrument them using byte code instrumentation. Changing the
I would prefer that to be a different change.
Thanks,
/Staffan
On 7 feb 2014, at 12:07, Dmitry Samersoff wrote:
> Staffan,
>
> As far as you touching this.
>
> Is it possible to change all native methods in these two classes to have
> 0 at the end of name?
>
> i.e. readBytes => readBytes0
>
Staffan,
As far as you touching this.
Is it possible to change all native methods in these two classes to have
0 at the end of name?
i.e. readBytes => readBytes0
it's pure cosmetic, but fairly simplify core dump reading and later
grep-ing.
-Dmitry
On 2014-02-07 14:46, Staffan Larsen wrote:
>
On 07/02/2014 10:46, Staffan Larsen wrote:
A few of the public read and write methods in FileInputStream and
RandomAccessFile are declared native. This means that it is hard to instrument
them using byte code instrumentation. Changing the public methods to be to
non-native and instead calling
A few of the public read and write methods in FileInputStream and
RandomAccessFile are declared native. This means that it is hard to instrument
them using byte code instrumentation. Changing the public methods to be to
non-native and instead calling private native methods simplifies
instrument
