Re: RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Erik Joelsson
Looks good. /Erik On 2020-02-13 10:08, Igor Ignatev wrote: Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and apparently forgot to replace the webrev, the right is http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with version field value being the only

Re: RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Joe Wang
+1 for the change to test/jaxp/TEST.ROOT. Best, Joe On 2/13/20 10:08 AM, Igor Ignatev wrote: Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and apparently forgot to replace the webrev, the right is http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with

Re: RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Igor Ignatev
Oh, I’m sorry I actually changed it to 5.0 when were (re)doing testing, and apparently forgot to replace the webrev, the right is http://cr.openjdk.java.net/~iignatyev//8238943/webrev.01 ; with version field value being the only difference b/w .00 and .01 Thanks, — Igor > On Feb 13, 2020, at

Re: RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Erik Joelsson
Looks good, but could you change the "version" field to "5.0", it should work now. /Erik On 2020-02-13 08:50, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00 10 lines changed: 1 ins; 0 del; 9 mod; Hi all, could you please review the patch which changes jtreg

Re: RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Jonathan Gibbons
Igor, The change to langtools/TEST.ROOT is OK. That being said, there are some old entries there which could also be cleaned up (separately?)  These lines probably date from the development of JDK 9 and the evolution of Project Jigsaw. 20 # Use new module options 21

RFR(S) : 8238943: switch to jtreg 5.0

2020-02-13 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8238943/webrev.00 > 10 lines changed: 1 ins; 0 del; 9 mod; Hi all, could you please review the patch which changes jtreg version used in jdk/jdk to the latest and greatest -- jtreg 5.0? and as (recently became) usually, this patch also bumps