Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

2020-06-26 Thread Daniel D. Daugherty
On 6/26/20 2:41 AM, Alan Bateman wrote: On 25/06/2020 22:45, Daniel D. Daugherty wrote: Here's the context diff: $ hg diff diff -r cf65909b98c5 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt    Thu Jun 25 15:00:59 2020 -0400 +++ b/test/jdk/ProblemList.txt    Thu Jun 25 17:39:01 2020

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

2020-06-26 Thread Alan Bateman
On 25/06/2020 22:45, Daniel D. Daugherty wrote: Here's the context diff: $ hg diff diff -r cf65909b98c5 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt    Thu Jun 25 15:00:59 2020 -0400 +++ b/test/jdk/ProblemList.txt    Thu Jun 25 17:39:01 2020 -0400 @@ -630,6 +630,8 @@  

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

2020-06-25 Thread Daniel D. Daugherty
Thanks for the fast review Igor! Dan On 6/25/20 6:38 PM, Igor Ignatyev wrote: Hi Dan, LGTM Thanks, -- Igor JDK-8248358 ProblemList serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on Windows https://bugs.openjdk.java.net/browse/JDK-8248358 I guess you

Re: RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

2020-06-25 Thread Igor Ignatyev
Hi Dan, LGTM Thanks, -- Igor > JDK-8248358 ProblemList > serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on > Windows > https://bugs.openjdk.java.net/browse/JDK-8248358 I guess you meant JDK-8248358 ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

RFR(T): 8248358: ProblemList sun/nio/ch/TestMaxCachedBufferSize.java on macOSX

2020-06-25 Thread Daniel D. Daugherty
Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bug for the failures:     JDK-8212812 sun/nio/ch/TestMaxCachedBufferSize.java timeout     https://bugs.openjdk.java.net/browse/JDK-8212812