Re: RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

2020-07-09 Thread David Holmes
On 9/07/2020 7:24 am, Daniel D. Daugherty wrote: Thanks for the fast review. I was surprised that jcheck -r tip didn't flag that, but... :-) jcheck doesn't check copyright lines or file headers. Cheers, David Dan On 7/8/20 5:23 PM, igor.ignat...@oracle.com wrote: LGTM, thanks for

Re: RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

2020-07-08 Thread Daniel D. Daugherty
Thanks for the fast review. I was surprised that jcheck -r tip didn't flag that, but... :-) Dan On 7/8/20 5:23 PM, igor.ignat...@oracle.com wrote: LGTM, thanks for fixing, and sorry for introducing that. — Igor On Jul 8, 2020, at 2:22 PM, Daniel D. Daugherty wrote: Greetings, A

Re: RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

2020-07-08 Thread igor . ignatyev
LGTM, thanks for fixing, and sorry for introducing that. — Igor > On Jul 8, 2020, at 2:22 PM, Daniel D. Daugherty > wrote: > > Greetings, > > A trivial fix to make the validate-header Tier1 task happy. > > Here's the context diff: > > $ hg diff -r qparent > diff -r c5202ed40b86

RFR(T): 8249097: test/lib/jdk/test/lib/util/JarBuilder.java has a bad copyright

2020-07-08 Thread Daniel D. Daugherty
Greetings, A trivial fix to make the validate-header Tier1 task happy. Here's the context diff: $ hg diff -r qparent diff -r c5202ed40b86 test/lib/jdk/test/lib/util/JarBuilder.java --- a/test/lib/jdk/test/lib/util/JarBuilder.java    Wed Jul 08 20:35:36 2020 +0100 +++