RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

2020-04-28 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 > 16 lines changed: 0 ins; 0 del; 16 mod; Hi all, could you please review this trivial cleanup in tests? from JBS: > ClassFileInstaller is a test utility class which copies class files to the > current directory, there is no point in runni

Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

2020-04-28 Thread Ioi Lam
Looks good and trivial. Thanks - Ioi On 4/28/20 9:41 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 16 lines changed: 0 ins; 0 del; 16 mod; Hi all, could you please review this trivial cleanup in tests? from JBS: ClassFileInstaller is a test utility class

Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

2020-04-28 Thread Igor Ignatyev
thanks Ioi for such a prompt review, pushed. -- Igor > On Apr 28, 2020, at 9:47 PM, Ioi Lam wrote: > > Looks good and trivial. > > Thanks > - Ioi > > On 4/28/20 9:41 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 >>> 16 lines changed: 0 ins; 0 del; 16 mod

Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

2020-04-28 Thread Stefan Karlsson
Looks good. StefanK On 2020-04-29 06:41, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8244066/webrev.00 16 lines changed: 0 ins; 0 del; 16 mod; Hi all, could you please review this trivial cleanup in tests? from JBS: ClassFileInstaller is a test utility class which copies cla

Re: RFR(T) : 8244066 : ClassFileInstaller should be run in driver mode

2020-04-29 Thread Igor Ignatyev
Hi Stefan, I've already pushed it (right after Ioi reviewed it), nevertheless I appreciate you reviewing it. -- Igor > On Apr 28, 2020, at 11:11 PM, Stefan Karlsson > wrote: > > Looks good. > > StefanK > > On 2020-04-29 06:41, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev/