Hi Mandy,
Thanks for taking another look.
On 6/3/20 2:07 PM, Mandy Chung wrote:
On 6/3/20 12:34 PM, Calvin Cheung wrote:
I saw David has commented on this. So I'll leave the assert as before
and I've added another assert (see line 1691):
1687 // The following ensures that the caller's
On 6/3/20 12:34 PM, Calvin Cheung wrote:
I saw David has commented on this. So I'll leave the assert as before
and I've added another assert (see line 1691):
1687 // The following ensures that the caller's nest host is the
same as the lambda proxy's
1688 // nest host recorded at dump
Hi David,
On 6/2/20 10:30 PM, David Holmes wrote:
1685 InstanceKlass* n_h = caller_ik->nest_host(THREAD);
1686 assert(n_h->has_nest_member(caller_ik, THREAD) ||
1687 n_h == caller_ik, "mismatched nest host");
I think you meant to check n_h->has_nest_member(loaded_lambda, THREAD).
T
Hi Mandy,
Thanks for your review.
On 6/2/20 11:38 AM, Mandy Chung wrote:
Hi Calvin,
To recap an offline discussion, I think we should use JDK bootcycle
build to test this feature. For example generating a boot JDK with
archived lambda proxy classes for java.base and javac to build itself
a
Hi Mandy,
On 3/06/2020 4:38 am, Mandy Chung wrote:
Hi Calvin,
To recap an offline discussion, I think we should use JDK bootcycle
build to test this feature. For example generating a boot JDK with
archived lambda proxy classes for java.base and javac to build itself
and also use it to run J
Hi Calvin,
To recap an offline discussion, I think we should use JDK bootcycle
build to test this feature. For example generating a boot JDK with
archived lambda proxy classes for java.base and javac to build itself
and also use it to run JDK tier 1-3 tests. This would serve a good test
bed
RFE: https://bugs.openjdk.java.net/browse/JDK-8198698
webrev: http://cr.openjdk.java.net/~ccheung/jdk15/8198698/webrev.00/
There's a high level design doc in the attachment[1] of the RFE.
Passed tiers 1 - 4 tests (including the new tests).
thanks,
Calvin
[1]
https://bugs.openjdk.java.net/se
