Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-16 Thread Alan Bateman
On 16/07/2014 03:48, Mikael Vidstedt wrote: Please review the below change which adds support for running jtreg tests from the top level test/ directory using the 'make TESTDIRS=path jtreg_tests' syntax. The TESTDIRS syntax is already used in files like hotspot/test/Makefile and

RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread Mikael Vidstedt
Please review the below change which adds support for running jtreg tests from the top level test/ directory using the 'make TESTDIRS=path jtreg_tests' syntax. The TESTDIRS syntax is already used in files like hotspot/test/Makefile and jdk/test/Makefile and allows for selecting which jtreg

Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread Mikael Vidstedt
I suppose a webrev helps: http://cr.openjdk.java.net/~mikael/webrevs/8050825/webrev.00/webrev/ Sorry 'bout that. Cheers, Mikael On 2014-07-15 19:48, Mikael Vidstedt wrote: Please review the below change which adds support for running jtreg tests from the top level test/ directory using

Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread Mike Duigou
This looks like a nice improvement and provides a good way to execute specific sub-sets that are smaller than the TEST.groups definitions. I'd like to hook it up to the top level make as an alternative to the current recipe. make test TEST=jdk_core Perhaps adjust the top level make test

Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread David Holmes
Looks okay to me. To be clear, the format of the path is not flexible but must have the form ../component/test/... David On 16/07/2014 12:51 PM, Mikael Vidstedt wrote: I suppose a webrev helps: http://cr.openjdk.java.net/~mikael/webrevs/8050825/webrev.00/webrev/ Sorry 'bout that.

Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread Mikael Vidstedt
On 2014-07-15 20:04, Mike Duigou wrote: This looks like a nice improvement and provides a good way to execute specific sub-sets that are smaller than the TEST.groups definitions. I'd like to hook it up to the top level make as an alternative to the current recipe. make test TEST=jdk_core

Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread Mikael Vidstedt
Correct, the path needs to be on that format! Thanks for the review! Thanks, Mikael On 2014-07-15 20:15, David Holmes wrote: Looks okay to me. To be clear, the format of the path is not flexible but must have the form ../component/test/... David On 16/07/2014 12:51 PM, Mikael Vidstedt

Re: RFR(XS): 8050825: Support running regression tests using jtreg_tests+TESTDIRS from top level

2014-07-15 Thread Mike Duigou
I will probably try to fix that eventually. I had some shell code which re-resolved a path relative to another path. In particular, for top level make execution the ../ portion would be incorrect. Anyway, this seems good enough for now. We can make it more flexible later. Mike On Jul 15