s-dev"
Date: 06/01/2018 01:34PM
Cc: Java Core Libs
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
Hi Thomas,
Sorry, I was on vacation. I will submit webrev with jtreg testcase.
Thanks,
Bhaktavatsal
-"Thomas Stüfe" wrote: -
To: Bhakt
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
Hi Bhaktavatsal,
the fix is fine. Reviewed. Thanks a lot for your work!
Could you please (its okay in a future patch) add a regression test
for IBM943 and IBM943C, in the form of a jtreg test? I would like to
test conve
<thomas.stu...@gmail.com>
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs
> <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and rev
On Mon, May 21, 2018 at 10:00 AM, Alan Bateman wrote:
> On 21/05/2018 08:53, Thomas Stüfe wrote:
>>
>> On Mon, May 21, 2018 at 9:52 AM, Thomas Stüfe
>> wrote:
>>>
>>> Hi Bhaktavatsal,
>>>
>>> sorry, I have not had time to look at it yet. Too much
On 21/05/2018 08:53, Thomas Stüfe wrote:
On Mon, May 21, 2018 at 9:52 AM, Thomas Stüfe wrote:
Hi Bhaktavatsal,
sorry, I have not had time to look at it yet. Too much unforeseen work.
If there is another one wanting to review
(preferably someone from Oracles core
ibm.com>
>> From: "Thomas Stüfe" <thomas.stu...@gmail.com>
>> Date: 05/11/2018 11:49AM
>> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs
>> <core-libs-dev@openjdk.java.net>
>> Subject: Re: RFR(XS): 8202329 [AIX]
ktavatsal R Maram
> <bhama...@in.ibm.com>
> From: "Thomas Stüfe" <thomas.stu...@gmail.com>
> Date: 05/11/2018 11:49AM
> Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs
> <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 82
..@gmail.com>
Date: 05/11/2018 11:49AM
Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
Hi,
I'll test and review next week. We also have some in-house t
ail.com>, Java Core Libs
> <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
>
> Hi,
>
> I'll test and review next week. We also have some in-house tests which
> I'd like to run.
>
> You I
..@gmail.com>
Date: 05/11/2018 11:49AM
Cc: Volker Simonis <volker.simo...@gmail.com>, Java Core Libs
<core-libs-dev@openjdk.java.net>
Subject: Re: RFR(XS): 8202329 [AIX] Fix codepage mappings for IBM-943 and Big5
Hi,
I'll test and review next week. We also have some in-house tests w
Hi,
I'll test and review next week. We also have some in-house tests which
I'd like to run.
You IBM folks should really apply for authorship so that this
contribution process gets streamlined. After all, if something breaks
in this code, you want to be able to fix it, yes? So even if you do
not
Hi.
I tested this fix on AIX.
I got following results.
$ LANG=Ja_JP ~/jdk/bin/java PrintDefaultCharset
Ja_JP x-IBM943C IBM-943CIBM-943C
$ LANG=Ja_JP.IBM-943 ~/jdk/bin/java PrintDefaultCharset
Ja_JP.IBM-943 x-IBM943C IBM-943CIBM-943C
$ LANG=Zh_TW ~/jdk/bin/java
Hi Bhaktavatsal Reddy,
your change looks good. I can sponsor it.
Just waiting for a second review...
Thank you and best regards,
Volker
On Mon, Apr 30, 2018 at 11:29 AM, Bhaktavatsal R Maram
wrote:
> Hi All,
>
> Please review the fix.
>
> bug:
Hi All,
Please review the fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8202329
webrev: http://cr.openjdk.java.net/~aleonard/8202329/webrev.00/
Thanks,
Bhaktavatsal Reddy
-"core-libs-dev" wrote: -
To: Volker Simonis
14 matches
Mail list logo